Bug 909394

Summary:	net-libs/nodejs: disable lto, or package.use.mask it?
Product:	Gentoo Linux	Reporter:	Joonas Niilola <juippis>
Component:	Current packages	Assignee:	William Hubbs <williamh>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=906517 https://bugs.gentoo.org/show_bug.cgi?id=909305 https://bugs.gentoo.org/show_bug.cgi?id=851582
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	618550

Description Joonas Niilola gentoo-dev

2023-06-30 07:32:53 UTC

Hey, 

I propose disabling lto altogether from nodejs. While it may compile it's crashing builds elsewhere, notably with big packages like chromium, firefox and thunderbird. We've recently had few reports in the forums:
https://forums.gentoo.org/viewtopic-t-1164017-highlight-nodejs+lto.html
https://forums.gentoo.org/viewtopic-t-1163776-highlight-nodejs+lto.html
(and search "nodejs lto" to find more older ones)

Then there's at least bug 906517, bug 909305, and bug 851582. Currently lto enabled in nodejs seems risky. 

Or in my opinion it should be package.use.mask'd at least.

I can imagine chromium, firefox and thunderbird to depend on nodejs[-lto] too, but that seems weird, and doesn't protect other chromium/firefox -based packages. And other possible unidentified packages affected by this.

Comment 1 William Hubbs gentoo-dev

2023-06-30 19:41:41 UTC

I have disabled LTO for now.

Comment 2 William Hubbs gentoo-dev

2023-06-30 19:42:11 UTC

Sorry about the typo, I have package.use.masked it.

Comment 3 Larry the Git Cow gentoo-dev

2023-06-30 19:44:30 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=907577ae1da47c21556eeeb4386cdf2faa7b6754

commit 907577ae1da47c21556eeeb4386cdf2faa7b6754
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2023-06-30 19:31:25 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2023-06-30 19:44:24 +0000

    profiles/base/package.use.mask: mask lto for nodejs
    
    Closes: https://bugs.gentoo.org/909394
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 profiles/base/package.use.mask | 4 ++++
 1 file changed, 4 insertions(+)

Comment 4 Joonas Niilola gentoo-dev

2023-07-01 06:20:16 UTC

Thanks!