Bug 909387

Summary:	media-libs/freetype-2.13.1 USE=-cleartype-hinting has no effect
Product:	Gentoo Linux	Reporter:	Tom Gillespie <tgbugs>
Component:	Current packages	Assignee:	Gentoo Fonts Team <fonts>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sam
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/32313 https://gitlab.freedesktop.org/freetype/freetype/-/issues/1247
Whiteboard:
Package list:		Runtime testing required:	---

Description Tom Gillespie 2023-06-29 22:06:02 UTC

When updating from freetype-2.13.0 to 2.13.1 the -cleartype-hinting USE flag no longer disables hinting.

Reproducible: Always

Steps to Reproduce:
1. set -cleartype-hinting
2. emerge -1q freetype-2.13.1
3. open a terminal and scream in anguish as everything has gone wrong


Expected Results:  
Hinting should remain completely off, disable, removed, and forbidden from the system.

Comment 1 Matt Whitlock 2023-08-15 01:19:37 UTC

Yep. Ran into this myself and filed an issue upstream:

https://gitlab.freedesktop.org/freetype/freetype/-/issues/1247

Turns out, it's a problem with Gentoo's ebuild, so I opened a PR to fix it:

https://github.com/gentoo/gentoo/pull/32313

Comment 2 Larry the Git Cow gentoo-dev

2023-08-15 05:18:23 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4b33d5da945a0200bf4debdc54ef4d39d3280fb6

commit 4b33d5da945a0200bf4debdc54ef4d39d3280fb6
Author:     Matt Whitlock <gentoo@mattwhitlock.name>
AuthorDate: 2023-08-15 00:58:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-15 05:17:15 +0000

    media-libs/freetype: drop "infinality" USE flag
    
    Upstream have dropped support for the Infinality rasterizer as of
    release 2.13.1.
    
    Now the TT_CONFIG_OPTION_SUBPIXEL_HINTING macro is a boolean (i.e.,
    defined or undefined) rather than a bitmap (0b00, 0b01, 0b10, or 0b11),
    so we tweak the relevant disable_option logic in the ebuild.
    
    See: https://sourceforge.net/projects/freetype/files/freetype2/2.13.1/
    Closes: https://bugs.gentoo.org/909387
    Signed-off-by: Matt Whitlock <gentoo@mattwhitlock.name>
    Closes: https://github.com/gentoo/gentoo/pull/32313
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/freetype/freetype-2.13.1-r1.ebuild | 255 ++++++++++++++++++++++++++
 media-libs/freetype/freetype-9999.ebuild      |  13 +-
 2 files changed, 258 insertions(+), 10 deletions(-)

Comment 3 Sam James archtester

2023-08-15 05:18:59 UTC

(In reply to Matt Whitlock from comment #1)
> Yep. Ran into this myself and filed an issue upstream:
> 
> https://gitlab.freedesktop.org/freetype/freetype/-/issues/1247
> 
> Turns out, it's a problem with Gentoo's ebuild, so I opened a PR to fix it:
> 
> https://github.com/gentoo/gentoo/pull/32313

Thank you, as ever, Matt.

Also, sorry for missing this bug when it was first filed.