Bug 909307 – media-video/makemkv-1.17.4 fails to build with ffmpeg 6.0

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description chris williams 2023-06-27 15:36:23 UTC]

After upgrading ffmpeg to 6.0-r1, makemkv needs to be rebuilt and it fails on the following: ffabi.c:(.text+0x67f): undefined reference to `av_mallocz_array'.

It appears that this is a known issue upstream and the fix for this is to edit makemkv-oss source file libffabi/src/ffabi.c and replace "av_mallocz_array" with "av_calloc" and recompile.  
https://forum.makemkv.com/forum/viewtopic.php?f=3&t=30396

Reproducible: Always

Steps to Reproduce:
1. Upgrade ffmpeg to 6.0-r1
2. Run emerge @preserved-rebuild
3. makemkv fails
Actual Results:  
The following gets spit out:

/usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: tmp/libffabi/src/ffabi.c.o: in function `ffm_audio_encode_init':
ffabi.c:(.text+0x67f): undefined reference to `av_mallocz_array'
collect2: error: ld returned 1 exit status
make: *** [Makefile:89: out/libmakemkv.so.1.full] Error 1


Expected Results:  
It should rebuild without issues.

emerge --info '=media-video/makemkv-1.17.4::gentoo'

Portage 3.0.49 (python 3.11.4-final-0, default/linux/amd64/17.1, gcc-13, glibc-2.37-r3, 6.1.35-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-6.1.35-gentoo-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.37
KiB Mem:    65772048 total,  53149180 free
KiB Swap:    7999484 total,   7999484 free
Timestamp of repository gentoo: Tue, 27 Jun 2023 14:00:01 +0000
Head commit of repository gentoo: a93b8565e49925bec85f280bea0e51d3440e0084
Head commit of repository steam-overlay: f5d81890625d21bcc8e1f903cc471daab0951403

sh bash 5.2_p15-r6
ld GNU ld (Gentoo 2.40 p5) 2.40.0
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p15-r6::gentoo
dev-java/java-config:      2.3.1-r1::gentoo
dev-lang/perl:             5.36.1-r2::gentoo
dev-lang/python:           3.11.4::gentoo
dev-lang/rust:             1.69.0-r1::gentoo
dev-util/cmake:            3.26.4-r1::gentoo
dev-util/meson:            1.1.1::gentoo
sys-apps/baselayout:       2.13-r1::gentoo
sys-apps/openrc:           0.47.1::gentoo
sys-apps/sandbox:          2.32::gentoo
sys-devel/autoconf:        2.13-r8::gentoo, 2.71-r6::gentoo
sys-devel/automake:        1.16.5-r1::gentoo
sys-devel/binutils:        2.40-r5::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           15.0.7-r3::gentoo, 16.0.6::gentoo
sys-devel/gcc:             13.1.1_p20230527::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/lld:             15.0.7::gentoo
sys-devel/llvm:            15.0.7-r3::gentoo, 16.0.6::gentoo
sys-devel/make:            4.4.1-r1::gentoo
sys-kernel/linux-headers:  6.4::gentoo (virtual/os-headers)
sys-libs/glibc:            2.37-r3::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    volatile: False
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts:
    sync-rsync-verify-jobs: 1

steam-overlay
    location: /usr/local/portage/steam-overlay
    sync-type: git
    sync-uri: https://github.com/anyc/steam-overlay.git
    masters: gentoo
    priority: 50
    volatile: True

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA PUEL MakeMKV-EULA PUEL-11"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=znver2 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=znver2 -O2 -pipe"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-march=znver2 -O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=znver2 -O2 -pipe"
GENTOO_MIRRORS="http://mirror.leaseweb.com/gentoo/  http://gentoo.cs.utah.edu/ http://mirror.rackspace.com/gentoo/ http://mirrors.rit.edu/gentoo/ http://www.gtlib.gatech.edu/pub/gentoo http://gentoo.gossamerhost.com http://mirror.csclub.uwaterloo.ca/gentoo-distfiles/ http://gentoo.mirrors.ovh.net/gentoo-distfiles/ https://mirror.rackspace.com/gentoo/ http://mirror.datapipe.net/gentoo"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LEX="flex"
MAKEOPTS="-j33"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X a52 aac acl acpi alsa amd64 bluray bzip2 cairo cdda cdr cli crypt cups dri dvd dvdr elogind exif ffmpeg flac fortran gallium gdbm iconv ipv6 jpeg libnotify libtirpc mp3 mp4 mpeg multilib ncurses nls nptl offensive ogg opengl openmp pam pcre pdf png pulseaudio readline seccomp spell split-usr ssl test-rust tiff truetype udev udisks unicode usb vim-syntax vorbis x264 xattr xcb xml xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2021" ALSA_CARDS="snd_hda_intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="BPF NVPTX" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-4" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" RUBY_TARGETS="ruby31" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS

=================================================================
                        Package Settings
=================================================================

media-video/makemkv-1.17.4::gentoo was built with the following:
USE="gui java" ABI_X86="(64)"
CFLAGS="-march=znver2 -Os -pipe"
CXXFLAGS="-march=znver2 -Os -pipe"

[Comment 1 Arve Barsnes 2023-06-28 10:23:52 UTC]

Can confirm that the patch from that forum thread allows it to build

[Comment 2 Larry the Git Cow 2023-07-10 18:57:06 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a09ba8ba17ff0c374918d4a7dc6b63ff20a10abe

commit a09ba8ba17ff0c374918d4a7dc6b63ff20a10abe
Author:     Piotr Karbowski <[e-mail]>
AuthorDate: 2023-07-10 18:56:22 +0000
Commit:     Piotr Karbowski <[e-mail]>
CommitDate: 2023-07-10 18:57:04 +0000

    media-video/makemkv: 1.17.4-r1 revbump with ffmpeg-6 support.
    
    Closes: https://bugs.gentoo.org/909307
    Signed-off-by: Piotr Karbowski <[e-mail]>

 media-video/makemkv/files/makemkv-ffmpeg-6.patch |  13 +++
 media-video/makemkv/makemkv-1.17.4-r1.ebuild     | 128 +++++++++++++++++++++++
 2 files changed, 141 insertions(+)