Bug 908740

Summary:	[kde overlay] kde-apps/okular-9999 cmake error at upstream 9f498c7f5
Product:	Gentoo Linux	Reporter:	Duncan <1i5t5.duncan>
Component:	Overlays	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED OBSOLETE
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://bugs.kde.org/show_bug.cgi?id=471173
Whiteboard:
Package list:		Runtime testing required:	---

Description Duncan 2023-06-18 00:36:53 UTC

So upstream okular messed up the USE=-test option again, but this time our patches still apply cleanly so I get a clean cmake error with USE=-test (builds fine with USE=test, still FEATURES=-test), instead of the more usual every-few-months gentoo-level patch application failure.

The upstream culprit (emails despammed) is:
commit 9f498c7f5
Author:     Sune Vuorela <sune@vuo...>
AuthorDate: Thu Apr 20 16:17:41 2023 +0200
Commit:     Nate Graham <nate@...>
CommitDate: Wed Jun 14 17:47:41 2023 +0000

Allow new signatures to have image backgrounds


The cmake error is:

CMake Error at generators/poppler/CMakeLists.txt:40 (target_compile_definitions):
Cannot specify compile definitions for target "imageScalingTest" which is
not built by this project.


I filed an upstream bug for it at https://bugs.kde.org/show_bug.cgi?id=471173 but then noticed/remembered that gentoo is already applying okular-21.11.80-tests.patch so perhaps upstream isn't receptive to such things and we just update our existing patch to account for the new USE=-test failure as well?

Comment 1 Duncan 2023-06-26 03:49:37 UTC

Hmm... no problem now.  Without bisecting the fix I suspect upstream 5f2f84457 fixed it (it removes the line named in the error), despite the "never left my computer" wording in its commit entry and the upstream-closed bug saying it was downstream gentoo.

RESOLVED/OBSOLETE seems most accurate.

Comment 2 Andreas Sturmlechner gentoo-dev

2023-06-26 11:02:38 UTC

Glad I didn't spend any time on it then.