Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 908560

Summary: dev-python/pytest-env-0.8.1: test suite is extremely fragile
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Marek Szuba <marecki>
Status: RESOLVED FIXED    
Severity: normal CC: python, qa
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/pytest-dev/pytest-env/issues/48
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: dev-python:pytest-env-0.8.1:20230616-031107.log

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-06-16 03:33:38 UTC
Created attachment 863891 [details]
dev-python:pytest-env-0.8.1:20230616-031107.log

The test suite strips environment, breaking random other pytest plugins.  Furthermore, it also strips PYTEST_DISABLE_PLUGIN_AUTOLOAD, so it breaks disabling other plugins.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-08-22 18:44:15 UTC
Ping.  This package is still untestable.
Comment 2 Marek Szuba (RETIRED) archtester gentoo-dev 2023-08-22 20:43:03 UTC
I presume this means you want the test suite disabled? If so go right ahead, if it can't be tested reliably then it's probably better not to try in the first place.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-08-23 03:50:34 UTC
No, I want it fixed.  Make a patch, send it upstream.  That's how we solve problems in Gentoo.
Comment 4 Marek Szuba (RETIRED) archtester gentoo-dev 2023-08-23 11:20:19 UTC
In that case go right ahead too. python@g.o. does co-maintain this package, and clearly you know much more about this problem than I do (for one thing, I have yet to actually reproduce it).
Comment 5 Larry the Git Cow gentoo-dev 2023-08-24 14:31:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=10d6110bd40d4407c4bb81db3ff77f8e42163d27

commit 10d6110bd40d4407c4bb81db3ff77f8e42163d27
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2023-08-24 14:30:34 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2023-08-24 14:30:34 +0000

    dev-python/pytest-env: Fix the test suite w/ other plugins
    
    Closes: https://bugs.gentoo.org/908560
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../pytest-env/files/pytest-env-1.0.0-test.patch   | 36 ++++++++++++++++++++++
 dev-python/pytest-env/pytest-env-1.0.0.ebuild      | 30 +++++++++++++++---
 2 files changed, 61 insertions(+), 5 deletions(-)