Bug 90823 – Various one line changes as recommended by pychecker.

• Product: Gentoo Release Media
• Status: RESOLVED FIXED

[Description Christopher Hotchkiss 2005-04-28 23:12:10 UTC]

Warnings...

GLIStorageDevice.py:1: Imported module (re) not used
GLIStorageDevice.py:72: Methods (_error) in Partition need to be overridden in a subclass
GLIStorageDevice.py:76: Methods (_error) in Partition need to be overridden in a subclass
GLIStorageDevice.py:79: Methods (_error) in Partition need to be overridden in a subclass
GLIStorageDevice.py:174: Setting free_minor to itself has no effect
GLIStorageDevice.py:202: Methods (_error) in Partition need to be overridden in a subclass
GLIStorageDevice.py:206: Methods (_error) in Partition need to be overridden in a subclass
GLIStorageDevice.py:208: Methods (_error) in Partition need to be overridden in a subclass
GLIStorageDevice.py:221: Methods (_error) in Partition need to be overridden in a subclass
GLIStorageDevice.py:325: Local variable (tmppart_log) not used
GLIStorageDevice.py:392: Raising string exceptions are deprecated (DeviceObjectError)
GLIStorageDevice.py:450: Function (__init__) has too many arguments (11)
GLIStorageDevice.py:519: Local variable (start) not used
GLIStorageDevice.py:704: Raising string exceptions are deprecated (PartitionObjectError)
GLIStorageDevice.py:742: (file) shadows builtin

Warnings...

GLIException.py:31: No class attribute (args) found
GLIException.py:37: No class attribute (args) found
GLIException.py:43: No class attribute (args) found
GLIException.py:49: No class attribute (args) found
GLIException.py:55: No class attribute (args) found

GLIUtility.py:9: Imported module (signal) not used
GLIUtility.py:9: Imported module (sys) not used
GLIUtility.py:9: Imported module (time) not used
GLIUtility.py:302: Parameter (quiet) not used
GLIUtility.py:357: (file) shadows builtin
GLIUtility.py:428: Function return types are inconsistent
GLIUtility.py:498: Local variable (i) not used

Warnings...

SimpleXMLParser.py:17: Base class (xml.sax.handler.ContentHandler) __init__() not called
SimpleXMLParser.py:66: Parameter (name) not used
SimpleXMLParser.py:111: Raising string exceptions are deprecated (NoFileGiven)


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Christopher Hotchkiss 2005-04-28 23:12:37 UTC]

Created attachment 57550 [details, diff]
GLIStorageDevice.py

[Comment 2 Christopher Hotchkiss 2005-04-28 23:12:56 UTC]

Created attachment 57551 [details, diff]
GLIUtility.py

[Comment 3 Christopher Hotchkiss 2005-04-28 23:13:11 UTC]

Created attachment 57552 [details, diff]
SimpleXMLParser.py

[Comment 4 Christopher Hotchkiss 2005-04-28 23:30:57 UTC]

Please note that the pychecker is just a guide. Some problems are fixed and other are ignored for now.

Ignored stuff
GLIUtility.spawn's quiet parameter is not used and can be removed, will have to fix everything that deps on it too
GLIUtility.get_eth_device returns four different ways. It seems to be two functions in one.

[Comment 5 Andrew Gaffney (RETIRED) 2005-04-28 23:42:37 UTC]

GLIStorageDevice changes in cvs

[Comment 6 Andrew Gaffney (RETIRED) 2005-05-09 21:26:32 UTC]

Comment on attachment 57551 [details, diff]
GLIUtility.py

applied

[Comment 7 Andrew Gaffney (RETIRED) 2005-05-09 21:29:05 UTC]

all patches applied

[Comment 8 Jeffrey Forman (RETIRED) 2006-03-24 13:46:29 UTC]

Moving to Release Media/Installer.