Bug 907966 – media-video/pipewire: Modify pipewire.desktop to use gentoo-pipewire-launcher 'restart'?

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Alexis 2023-06-07 00:21:43 UTC]

Opening this on the basis of this post on f.g.o:

https://forums.gentoo.org/viewtopic-p-8791739.html#8791739

The current login in gentoo-pipewire-launcher tries to avoid unnecessary restarts (in order to avoid unnecessary loss of audio output). However, this means that, with PW+WP instances not getting shut down at the end of an XDG session, they won't work with a new XDG session.

Ideally PW+WP would get shut down during the termination of an XDG session. A quick search didn't immediately indicate any a standard place in which this can be done; is there one? But at any rate, it seems to me that the 'Exec' line in pipewire.desktop should be changed to: 

    Exec=/usr/bin/gentoo-pipewire-launcher restart

to ensure that session-appropriate PW+WP instances are available even if the previous XDG session was not terminated cleanly.

Thoughts?

[Comment 1 Sam James 2023-06-07 00:39:52 UTC]

Another benefit from the restart feature. Sounds good. Gimme a patch to apply?

[Comment 2 Alexis 2023-06-07 07:29:16 UTC]

Created attachment 863446 [details, diff]
Add 'restart' to call of gentoo-pipewire-launcher.

[Comment 3 Alexis 2023-06-07 07:29:37 UTC]

(In reply to Sam James from comment #1)
> Another benefit from the restart feature. Sounds good. Gimme a patch to
> apply?

Done. :-)

[Comment 4 Larry the Git Cow 2023-06-07 09:52:23 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b96e100121529b7fbc6c23afdae5de8d425dd3ed

commit b96e100121529b7fbc6c23afdae5de8d425dd3ed
Author:     Alexis <[e-mail]>
AuthorDate: 2023-06-07 07:23:47 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-06-07 09:51:40 +0000

    media-video/pipewire: pipewire.desktop: Add 'restart' to call of gentoo-pipewire-launcher.
    
    Closes: https://bugs.gentoo.org/907966
    Signed-off-by: Alexis <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 media-video/pipewire/files/pipewire.desktop-r2 | 12 ++++++++++++
 media-video/pipewire/pipewire-0.3.71-r2.ebuild |  2 +-
 media-video/pipewire/pipewire-9999.ebuild      |  2 +-
 3 files changed, 14 insertions(+), 2 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c268e89f934af7a752e756e3207eae31f311cb19

commit c268e89f934af7a752e756e3207eae31f311cb19
Author:     Sam James <[e-mail]>
AuthorDate: 2023-06-07 09:47:59 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-06-07 09:47:59 +0000

    media-video/pipewire: add 0.3.71-r2 (unchanged from 0.3.71-r1 for now)
    
    Doing it this way to get a clean git history for the 2 changes from flexibeast.
    
    Bug: https://bugs.gentoo.org/907966
    Bug: https://bugs.gentoo.org/907891
    Signed-off-by: Sam James <[e-mail]>

 media-video/pipewire/pipewire-0.3.71-r2.ebuild | 461 +++++++++++++++++++++++++
 1 file changed, 461 insertions(+)

[Comment 5 Sam James 2023-06-07 09:53:02 UTC]

Thanks!