Bug 907697 – sys-apps/smc-sum-2.10.0.20221209-r1 neither linux-mod-r1_src_install nor modules_post_process were used

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2023-06-02 11:32:25 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-apps/smc-sum-2.10.0.20221209-r1 neither linux-mod-r1_src_install nor modules_post_process were used.
Discovered on: amd64 (internal ref: ci)

[Comment 1 Agostino Sarubbo 2023-06-02 11:32:27 UTC]

Created attachment 863044 [details]
build.log

build log and emerge --info

[Comment 2 Ionen Wolkens 2023-06-02 11:59:18 UTC]

This should use MODULES_OPTIONAL_IUSE rather than do `use module` manual checks.

[Comment 3 Ionen Wolkens 2023-06-02 12:26:01 UTC]

(In reply to Ionen Wolkens from comment #2)
> This should use MODULES_OPTIONAL_IUSE rather than do `use module` manual
> checks.
And sorry, missed that when I had a quick look. See eclassdocs but it makes the entire eclass into a no-op (including the pkg_postinst from where this QA notice came from), unless the flag is set. That means it'll be fine to just:

    src_compile() {
        local modargs=( KDIR="${KV_OUT_DIR}" )
        local modlist=( sum_bios="misc:driver/Source/Linux" )

        linux-mod-r1_src_compile
    }

without custom logic.

[Comment 4 Ionen Wolkens 2023-06-02 12:47:26 UTC]

Also, just noticed linux-mod-r1_pkg_setup is being ran in src_prepare. That means it's being ran twice with USE=module right now.

[Comment 5 Conrad Kostecki 2023-06-05 11:00:00 UTC]

Indeed. I am very sorry, my bad. Somehow, I totally forgot to test without enabling the module. I always have it on, since I need it for my supermicro hardware :-)

I really appreciate it, thank you for your great input. I have updated the ebuild, works now without any warnings/errors/problems.

[Comment 6 Larry the Git Cow 2023-06-05 11:05:18 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f26f5d09fec69b7e46995f1cc858177ec0dd2d0f

commit f26f5d09fec69b7e46995f1cc858177ec0dd2d0f
Author:     Conrad Kostecki <[e-mail]>
AuthorDate: 2023-06-05 11:01:50 +0000
Commit:     Conrad Kostecki <[e-mail]>
CommitDate: 2023-06-05 11:04:30 +0000

    sys-apps/smc-sum: fix build without module
    
    Closes: https://bugs.gentoo.org/907697
    Signed-off-by: Conrad Kostecki <[e-mail]>

 ...209-r1.ebuild => smc-sum-2.10.0.20221209-r2.ebuild} | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)