Bug 907065 – dev-libs/libxml2: please send Solaris fix upstream

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Sam James 2023-05-24 10:46:44 UTC]

We've had to work quite hard to get the libxml2 ebuild into a sane state with 0 patches and hoping to keep it clean.

Could you please report the Solaris issue for iconv upstream please and include a link to it in the ebuild? Ideally w/ a PR. Upstream do care about portability and are easy to work with.

We don't want to keep workarounds indefinitely with 0 reports if it's easy to fix, and this one should be.

Please add these references going forward too. I'll drop the workaround next week otherwise, as it's too prone to bitrot (nobody is going to be able to quickly verify if it's still needed).

(I accept the macOS Frameworks stuff is different because it really is Gentoo specific in a sense, but I think this case is totally generic and should be something that can be solved upstream.)

[Comment 1 Fabian Groffen 2023-05-24 15:04:27 UTC]

Hi Sam, upstream just rejected my bug because they think we should not use libiconv, and suggested we just pass -liconv like I did in the ebuild.  Do you have any suggestions on how this would be better for you?

[Comment 2 Sam James 2023-05-24 15:14:09 UTC]

Ew, that's disappointing :(

Can you try AM_ICONV? The configure check at https://gitlab.gnome.org/GNOME/libxml2/-/blob/master/configure.ac#L1029 doesn't look very sophisticated.

[Comment 3 Fabian Groffen 2023-05-24 15:17:13 UTC]

that's what probably should've been used, yes

[Comment 4 Fabian Groffen 2023-05-24 15:49:28 UTC]

I suggested a rough patch which I tested in the ebuild that seems to work to upstream.  Will see if they are receptive to that.

[Comment 5 Fabian Groffen 2023-05-25 06:00:08 UTC]

ok, upstream went another way:
https://gitlab.gnome.org/nwellnhof/libxml2/-/commit/9fd57df81508c4e0baf1feb141bf939ceb13ee7e

[Comment 6 Fabian Groffen 2023-05-25 10:34:20 UTC]

the alternative take was merged upstream https://gitlab.gnome.org/GNOME/libxml2/-/commit/9fd57df81508c4e0baf1feb141bf939ceb13ee7e

Would you like to apply this patch and eautoreconf, or are you OK with the append-libs workaround until the next release?

[Comment 7 Sam James 2023-05-26 05:31:48 UTC]

(In reply to Fabian Groffen from comment #6)
> the alternative take was merged upstream
> https://gitlab.gnome.org/GNOME/libxml2/-/commit/
> 9fd57df81508c4e0baf1feb141bf939ceb13ee7e
> 
> Would you like to apply this patch and eautoreconf, or are you OK with the
> append-libs workaround until the next release?

thanks! It's fine with me to keep append-libs for now as long as there's a comment to the bug & a note to drop it on next release

[Comment 8 Fabian Groffen 2023-05-26 06:58:56 UTC]

Unfortunately I messed up the bugref

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c077c1f373119e25e4522d7952e34283e3b5be2

commit 1c077c1f373119e25e4522d7952e34283e3b5be2
Author:     Fabian Groffen <[e-mail]>
AuthorDate: 2023-05-26 06:54:58 +0000
Commit:     Fabian Groffen <[e-mail]>
CommitDate: 2023-05-26 06:54:58 +0000

    dev-libs/libxml2: fixup for Solaris build-fix
    
    - add missing virtual/libiconv dependency
    - add note + bugref for Solaris workaround
    - remove workaround from live-ebuild, since a fix was applied upstream
    
    Closes: https://bugs.gentoo.org/735134
    Signed-off-by: Fabian Groffen <[e-mail]>

 dev-libs/libxml2/libxml2-2.11.4.ebuild | 3 +++
 dev-libs/libxml2/libxml2-9999.ebuild   | 5 +----
 2 files changed, 4 insertions(+), 4 deletions(-)