Summary: | games-simulation/openrct2-0.4.5 fails to compile (MUSL-SYSTEM): FileStream.cpp:25:20: error: ftello64 was not declared in this scope | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | Conrad Kostecki <conikost> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | sam |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/OpenRCT2/OpenRCT2/pull/21140 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 903611, 920477 | ||
Attachments: | build.log |
Description
Agostino Sarubbo
2023-05-23 11:44:39 UTC
Created attachment 862264 [details]
build.log
build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: CMakeFiles/libopenrct2.dir/src/openrct2/core/FileStream.cpp.o /var/tmp/portage/games-simulation/openrct2-0.4.5/work/OpenRCT2-0.4.5/src/openrct2/core/FileStream.cpp:25:20: error: 'ftello64' was not declared in this scope; did you mean 'ftello'? @sam: Any idea for this one? (In reply to Conrad Kostecki from comment #3) > @sam: Any idea for this one? See https://bugs.gentoo.org/903611#c0. At https://github.com/OpenRCT2/OpenRCT2/blob/e6bee21682d36af5b5580b5f14f8e065a847b350/src/openrct2/core/FileStream.cpp#L24, we *unconditionally* use ftello64 and friends on Linux, but this isn't right. On glibc, we can set FILE_OFFSET_BITS=64 to make ftello-act-LFS aware. On musl, ftello is already LFS aware. So, lines 24-27 can be removed if in the build system, we can add -D_FILE_OFFSET_BITS=64 somewhere. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca9c069f8fa8b9d2d52db549f8116c2b12df1c6c commit ca9c069f8fa8b9d2d52db549f8116c2b12df1c6c Author: Conrad Kostecki <conikost@gentoo.org> AuthorDate: 2024-01-04 21:06:55 +0000 Commit: Conrad Kostecki <conikost@gentoo.org> CommitDate: 2024-01-04 21:08:09 +0000 games-simulation/openrct2: fix musl build Closes: https://bugs.gentoo.org/906989 Signed-off-by: Conrad Kostecki <conikost@gentoo.org> .../openrct2/files/openrct2-0.4.7-musl.patch | 55 ++++++++++++++++++++++ games-simulation/openrct2/openrct2-0.4.7.ebuild | 1 + 2 files changed, 56 insertions(+) cheers conikost! |