Bug 906848 – app-doc/doxygen-1.9.7: bundled dev-libs/spdlog

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Klaus Kusche 2023-05-20 12:43:24 UTC]

The doxygen binary installed by doxygen-1.9.7.ebuild needs libspdlog.so.1.11 .

However, doxygen-1.9.7.ebuild does not depend on dev-libs/spdlog.

The doxygen build contains and also builds a bundled copy of spdlog,
so there is a libspdlog.so.1.11 in the build tree,
but it is not installed.

Manually emerging dev-libs/spdlog solved the problem.

I think a separately-installed libspdlog should be used (and depended on), 
not the bundled one?

Reproducible: Always

[Comment 1 Sam James 2023-05-20 12:45:36 UTC]

I'll take a look later today but someone is free to beat me.

[Comment 2 Sam James 2023-05-20 12:54:02 UTC]

My doxygen binary doesn't seem to need libspdlog.so.

It is indeed bundled though.

[Comment 3 Larry the Git Cow 2023-05-20 13:00:26 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4f8098bdc3db1817dcdf3956ec6dba61703f2ed4

commit 4f8098bdc3db1817dcdf3956ec6dba61703f2ed4
Author:     Sam James <[e-mail]>
AuthorDate: 2023-05-20 12:58:32 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-05-20 12:59:57 +0000

    app-doc/doxygen: fix spdlog usage
    
    It's linked statically normally but if we force dynamic linking, it ends up using but
    then not installing (bundled, just-built) libspdlog.
    
    Bug: https://bugs.gentoo.org/906848
    Signed-off-by: Sam James <[e-mail]>

 app-doc/doxygen/{doxygen-1.9.7.ebuild => doxygen-1.9.7-r1.ebuild} | 4 +++-
 app-doc/doxygen/doxygen-9999.ebuild                               | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

[Comment 4 Sam James 2023-05-20 13:01:00 UTC]

Fized that (the broken linking). Let's repurpose the bug for the general unbundling.

[Comment 5 Larry the Git Cow 2023-07-26 03:13:23 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=10c3fc41ee47042f6f3d16198e3fe178ec1d7752

commit 10c3fc41ee47042f6f3d16198e3fe178ec1d7752
Author:     David Roman <[e-mail]>
AuthorDate: 2023-06-22 15:14:23 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-07-26 03:11:47 +0000

    app-doc/doxygen: use system spdlog library
    
    Also drops obsolete use_sqlite3 option which has been
    removed from upstream.
    
    Bug: https://bugs.gentoo.org/906848
    Signed-off-by: David Roman <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/31573
    Signed-off-by: Sam James <[e-mail]>

 app-doc/doxygen/doxygen-9999.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[Comment 6 Sam James 2023-11-08 06:04:59 UTC]

And fixed in 1.9.8. Thank you David!