Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 906464

Summary: media-libs/gexiv2-0.14.1: gexiv2/gexiv2-metadata-gps.cpp:93:73: error: cannot convert ‘Exiv2::ErrorCode’ to ‘gint’ {aka ‘int’}
Product: Gentoo Linux Reporter: Andreas Sturmlechner <asturm>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal Keywords: PATCH, UPSTREAM
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://gitlab.gnome.org/GNOME/gexiv2/-/issues/74
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 906463    
Attachments: media-libs:gexiv2-0.14.1:20230515-185150.log

Description Andreas Sturmlechner gentoo-dev 2023-05-15 19:20:35 UTC
> ../gexiv2-0.14.1/gexiv2/gexiv2-metadata-gps.cpp:93:73: error: cannot convert ‘Exiv2::ErrorCode’ to ‘gint’ {aka ‘int’}
>    93 |         g_set_error_literal(error, g_quark_from_string("GExiv2"), e.code(), e.what());
>       |                                                                   ~~~~~~^~
>       |                                                                         |
>       |                                                                         Exiv2::ErrorCode
> In file included from /usr/include/glib-2.0/glib/gthread.h:35,
>                  from /usr/include/glib-2.0/glib/gasyncqueue.h:34,
>                  from /usr/include/glib-2.0/glib.h:34,
>                  from /usr/include/glib-2.0/gobject/gbinding.h:30,
>                  from /usr/include/glib-2.0/glib-object.h:24,
>                  from ../gexiv2-0.14.1/gexiv2/gexiv2-metadata.h:14,
>                  from ../gexiv2-0.14.1/gexiv2/gexiv2-metadata-gps.cpp:11:
> /usr/include/glib-2.0/glib/gerror.h:230:48: note:   initializing argument 3 of ‘void g_set_error_literal(GError**, GQuark, gint, const gchar*)’
>   230 |                                 gint           code,
>       |                                 ~~~~~~~~~~~~~~~^~~~
> ../gexiv2-0.14.1/gexiv2/gexiv2-metadata-gps.cpp: In function ‘gboolean gexiv2_metadata_try_get_gps_latitude(GExiv2Metadata*, gdouble*, GError**)’:
> ../gexiv2-0.14.1/gexiv2/gexiv2-metadata-gps.cpp:144:73: error: cannot convert ‘Exiv2::ErrorCode’ to ‘gint’ {aka ‘int’}
>   144 |         g_set_error_literal(error, g_quark_from_string("GExiv2"), e.code(), e.what());
>       |                                                                   ~~~~~~^~
>       |                                                                         |
>       |                                                                         Exiv2::ErrorCode
> /usr/include/glib-2.0/glib/gerror.h:230:48: note:   initializing argument 3 of ‘void g_set_error_literal(GError**, GQuark, gint, const gchar*)’
>   230 |                                 gint           code,
>       |                                 ~~~~~~~~~~~~~~~^~~~
> ../gexiv2-0.14.1/gexiv2/gexiv2-metadata-gps.cpp: In function ‘gboolean gexiv2_metadata_try_get_gps_altitude(GExiv2Metadata*, gdouble*, GError**)’:
> ../gexiv2-0.14.1/gexiv2/gexiv2-metadata-gps.cpp:184:73: error: cannot convert ‘Exiv2::ErrorCode’ to ‘gint’ {aka ‘int’}
>   184 |         g_set_error_literal(error, g_quark_from_string("GExiv2"), e.code(), e.what());
>       |                                                                   ~~~~~~^~
>       |                                                                         |
>       |                                                                         Exiv2::ErrorCode

...and so on.
Comment 1 Andreas Sturmlechner gentoo-dev 2023-05-15 19:36:15 UTC
Created attachment 861750 [details]
media-libs:gexiv2-0.14.1:20230515-185150.log
Comment 2 Andreas Sturmlechner gentoo-dev 2023-06-08 19:47:51 UTC
ArchLinux are using this patch:

https://gitlab.gnome.org/GNOME/gexiv2/-/commit/06adc8fb.patch
Comment 3 Andreas Sturmlechner gentoo-dev 2023-07-06 09:07:00 UTC
Even if there is still discussion in that upstream issue, https://gitlab.gnome.org/GNOME/gexiv2/-/commit/06adc8fb70cb8c77c0cd364195d8251811106ef8 applies fine over 0.14.1 makes it build fine against exiv2-0.28.0 on my ~amd64 system.
Comment 4 Larry the Git Cow gentoo-dev 2023-07-06 14:12:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3eaa5773c54b2ccddb1213b6d322e3e8badb84b9

commit 3eaa5773c54b2ccddb1213b6d322e3e8badb84b9
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-07-06 14:08:50 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-07-06 14:10:32 +0000

    media-libs/gexiv2: Add patch to fix compatibility with exiv2-0.28
    
    Closes: https://bugs.gentoo.org/906464
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 media-libs/gexiv2/Manifest                                          | 1 +
 media-libs/gexiv2/{gexiv2-0.14.1.ebuild => gexiv2-0.14.1-r1.ebuild} | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)