Bug 906343

Summary:	x11-wm/xpra-4.3.4-r1 adds -Werror flag on its own
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Benda Xu <heroxbd>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alexxy, chewi, esigra
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-05-14 20:06:14 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-wm/xpra-4.3.4-r1 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

Comment 1 Agostino Sarubbo gentoo-dev

2023-05-14 20:06:17 UTC

Created attachment 861686 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2023-05-16 22:16:14 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26532a745e96a2bcd4cab5e8d4a469133cec7055

commit 26532a745e96a2bcd4cab5e8d4a469133cec7055
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2023-05-16 22:15:53 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2023-05-16 22:15:53 +0000

    x11-wm/xpra: Set --without-strict to avoid -Werror
    
    I don't know why --with-strict was given before as it's a bad idea.
    
    Closes: https://bugs.gentoo.org/906343
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 x11-wm/xpra/xpra-4.3.4-r1.ebuild | 2 +-
 x11-wm/xpra/xpra-4.4.4.ebuild    | 2 +-
 x11-wm/xpra/xpra-9999.ebuild     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)