Bug 906189

Summary:	sys-power/acpid-2.0.34 fails to compile against musl-1.2.4: sock.c:57:23: error: storage size of st isnt known
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Marek Szuba (RETIRED) <marecki>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-05-12 06:37:35 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-power/acpid-2.0.34 fails to compile (MUSL-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc but this bug MAY or MAY NOT BE related to musl.

Comment 1 Agostino Sarubbo gentoo-dev

2023-05-12 06:37:37 UTC

Created attachment 861562 [details]
build.log

build log and emerge --info

Comment 2 Marek Szuba (RETIRED) archtester

2023-08-21 16:21:42 UTC

This looks like the culprit:

"On the API level, the legacy "LFS64" ("large file support") interfaces, which were provided by macros remapping them to their standard names (#define stat64 stat and similar) have been deprecated and are no longer provided under the _GNU_SOURCE feature profile, only under explicit _LARGEFILE64_SOURCE. The latter will also be removed in a future version. Builds broken by this change can be fixed short-term by adding -D_LARGEFILE64_SOURCE to CFLAGS, but should be fixed to use the standard interfaces."

Comment 3 Larry the Git Cow gentoo-dev

2023-08-21 16:36:34 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ee41125693765c77482e542de0d3b2f57df858a7

commit ee41125693765c77482e542de0d3b2f57df858a7
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2023-08-21 16:24:32 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2023-08-21 16:36:27 +0000

    sys-power/acpid: phase out legacy LFS interfaces
    
    acpid comes with its own implementation of isfdtype() for standard
    libraries which do not define it, like musl. This implementation used
    LFS interfaces, which are now deprecated and which since musl-1.2.4
    no longer are a part of the _GNU_SOURCE feature set. musl documentation
    says "just switch to standard interfaces" so let's do just that.
    
    Closes: https://bugs.gentoo.org/906189
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 sys-power/acpid/acpid-2.0.34-r1.ebuild       | 60 ++++++++++++++++++++++++++++
 sys-power/acpid/files/acpid-2.0.34-lfs.patch | 19 +++++++++
 2 files changed, 79 insertions(+)