Bug 906181 – [guru] sys-fs/dwarfs-0.7.0_rc4 fails to compile: AtFork.cpp:73:26: error: invalid_argument is not a member of std

• Product: GURU
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2023-05-12 06:27:18 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-fs/dwarfs-0.7.0_rc4 fails to compile.
Discovered on: amd64 (internal ref: guru_ci)

[Comment 1 Agostino Sarubbo 2023-05-12 06:27:20 UTC]

Created attachment 861555 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2023-05-12 06:27:21 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


--   Package 'fuse', required by 'virtual:world', not found
--   Package 'libbrotlidec', required by 'virtual:world', not found
--   Package 'libbrotlienc', required by 'virtual:world', not found
-- Could NOT find LIBAIO (missing: LIBAIO_LIBRARY LIBAIO_INCLUDE_DIR) 
-- Could NOT find LIBDWARF (missing: LIBDWARF_LIBRARY) 
-- Could NOT find LIBSODIUM (missing: LIBSODIUM_LIBRARY LIBSODIUM_INCLUDE_DIR) 
-- Could NOT find LIBURING (missing: LIBURING_LIBRARY LIBURING_INCLUDE_DIR) 
-- Could NOT find ZSTD (missing: ZSTD_INCLUDE_DIR) 
FAILED: folly/CMakeFiles/folly_base.dir/folly/system/AtFork.cpp.o 
/var/tmp/portage/sys-fs/dwarfs-0.7.0_rc4/work/dwarfs-0.7.0-RC4/folly/folly/system/AtFork.cpp:73:26: error: ‘invalid_argument’ is not a member of ‘std’

[Comment 3 Reva Denis 2023-05-12 07:13:13 UTC]

Thanks, it sounds like DEPEND var has incorrect values, that causes error in rare conditions. I'll fix it later when I have time.
That is especially weird:
--   Package 'fuse', required by 'virtual:world', not found
--   Package 'libbrotlidec', required by 'virtual:world', not found
--   Package 'libbrotlienc', required by 'virtual:world', not found

[Comment 4 Reva Denis 2023-05-16 09:19:51 UTC]

Caught it with clang. It is bundled lib issue. It might be even already fixed upstream. I'll work with it when I have time.

[Comment 5 Reva Denis 2023-05-16 09:20:21 UTC]

Depend does not have incorrect values, it's false positive error.

[Comment 6 Sam James 2023-05-16 09:23:43 UTC]

It cannot be a false positive, but further, the error tells you how to fix it:

/var/tmp/portage/sys-fs/dwarfs-0.7.0_rc4/work/dwarfs-0.7.0-RC4/folly/folly/system/AtFork.cpp:73:26: error: ‘invalid_argument’ is not a member of ‘std’
   73 |     throw_exception<std::invalid_argument>("at-fork: append: duplicate");
      |                          ^~~~~~~~~~~~~~~~
/var/tmp/portage/sys-fs/dwarfs-0.7.0_rc4/work/dwarfs-0.7.0-RC4/folly/folly/system/AtFork.cpp:23:1: note: ‘std::invalid_argument’ is defined in header ‘<stdexcept>’; did you forget to ‘#include <stdexcept>’?
   22 | #include <folly/synchronization/SanitizeThread.h>
  +++ |+#include <stdexcept>
   23 |

[Comment 7 Reva Denis 2023-05-16 09:28:46 UTC]

Sam James, I mean false-positive warnings about dependencies. But thanks.

[Comment 8 Larry the Git Cow 2023-05-19 18:51:17 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=9aaa47b79edc3a540b108fef69289c83f008983a

commit 9aaa47b79edc3a540b108fef69289c83f008983a
Author:     Denis Reva <[e-mail]>
AuthorDate: 2023-05-16 10:03:14 +0000
Commit:     Denis Reva <[e-mail]>
CommitDate: 2023-05-16 10:03:14 +0000

    sys-fs/dwarfs: fixed bug that appears with modern compilers
    
    clang-16 or gcc-13
    
    Closes: https://bugs.gentoo.org/906181
    Signed-off-by: Denis Reva <[e-mail]>

 sys-fs/dwarfs/dwarfs-0.7.0_rc4.ebuild                      |  5 +++++
 .../dwarfs/files/dwarfs-0.7.0_rc4-fbthrift-cstdint.patch   | 13 +++++++++++++
 sys-fs/dwarfs/files/dwarfs-0.7.0_rc4-stdexcept.patch       | 14 ++++++++++++++
 3 files changed, 32 insertions(+)