Summary: | sci-libs/pdal with gcc-13: pdal/Geometry.cpp:143:59: error: invalid conversion from 'const OGRSpatialReference*' to 'OGRSpatialReference*' [-fpermissive] | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | José de Paula Rodrigues <espinafre> |
Component: | Current packages | Assignee: | Thomas Bettler <thomas.bettler> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | espinafre, leonchik1976, proxy-maint, sci-geosciences |
Priority: | Normal | Keywords: | PATCH, PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/30999 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 865117 | ||
Attachments: |
build.log of sci-libs/pdal-2.4.3
allow pdal-2.4.3 build with gcc-13 allow pdal-2.5.3 build with gcc-13 allow pdal-2.5.3 build with gcc-13 allow pdal-2.4.3 build with gcc-13 allow pdal-2.4.3 build with gcc-13 |
Description
José de Paula Rodrigues
2023-05-11 01:30:23 UTC
Created attachment 861465 [details]
build.log of sci-libs/pdal-2.4.3
I should add that neither version 2.4.3 nor 2.5.3 (the ~amd64 one) ebuilds seems to accept user patches. Should I open another bug for this? (In reply to José de Paula Rodrigues from comment #2) > I should add that neither version 2.4.3 nor 2.5.3 (the ~amd64 one) ebuilds > seems to accept user patches. Should I open another bug for this? That doesn't sound right to me. Note that patches must end in .patch (iirc .diff may be accepted too): ``` mkdir -p /etc/portage/patches/sci-libs/pdal && echo "--- a/foo.c" >> /etc/portage/patches/sci-libs/pdal/foo.patch ``` and then.. ``` $ e pdal-2.5.3.ebuild clean prepare Appending /home/sam/git/gentoo to PORTDIR_OVERLAY... * PDAL-2.5.3-src.tar.bz2 BLAKE2B SHA512 size ;-) ... [ ok ] >>> Unpacking source... >>> Unpacking PDAL-2.5.3-src.tar.bz2 to /var/tmp/portage/sci-libs/pdal-2.5.3/work >>> Source unpacked in /var/tmp/portage/sci-libs/pdal-2.5.3/work >>> Preparing source in /var/tmp/portage/sci-libs/pdal-2.5.3/work/PDAL-2.5.3-src ... * Source directory (CMAKE_USE_DIR): "/var/tmp/portage/sci-libs/pdal-2.5.3/work/PDAL-2.5.3-src" * Build directory (BUILD_DIR): "/var/tmp/portage/sci-libs/pdal-2.5.3/work/PDAL-2.5.3-src_build" * ============================================================================================================================================================================================================= * Applying user patches from /etc/portage/patches ... * Applying foo.patch ... gpatch: **** Only garbage was found in the patch input. [ !! ] * ERROR: sci-libs/pdal-2.5.3::gentoo failed (prepare phase): * patch -p1 failed with /etc/portage/patches/sci-libs/pdal/foo.patch ``` so it does work. Of course, the patch filename has to end with '.patch', my bad. Here is a user patch that allows building sci-libs/pdal-2.4.3 against gcc-13 Created attachment 861467 [details, diff]
allow pdal-2.4.3 build with gcc-13
Created attachment 861468 [details, diff]
allow pdal-2.5.3 build with gcc-13
pdal-2.5.3 doesn't need <cstdint> included in a vendor/lazperf header file, unlike version 2.4.3.
@Jose thx for your contribution... can you also suggest this patch to upstream? (In reply to Thomas Bettler from comment #7) > @Jose thx for your contribution... can you also suggest this patch to > upstream? Hi, Thomas, while investigating the issue upstream, I found out that they already corrected in their master branch: https://github.com/PDAL/PDAL/commit/7b4b2d942bc0390d370d5b90f31daf77148005f6 They've used a different approach, I'm updating my user patch to reflect upstream change. Created attachment 861527 [details, diff]
allow pdal-2.5.3 build with gcc-13
Following upstream fix on master branch.
Created attachment 861528 [details, diff]
allow pdal-2.4.3 build with gcc-13
Following upstream fix on master branch.
Created attachment 861529 [details, diff]
allow pdal-2.4.3 build with gcc-13
Follow upstream fix.
*** Bug 906294 has been marked as a duplicate of this bug. *** The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d64174f63fa545f1c60913c1d244eba99483ec13 commit d64174f63fa545f1c60913c1d244eba99483ec13 Author: Thomas Bettler <thomas.bettler@gmail.com> AuthorDate: 2023-05-11 16:33:43 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-05-14 07:26:45 +0000 sci-libs/pdal: fix gcc-13 build Closes: https://bugs.gentoo.org/906102 Closes: https://github.com/gentoo/gentoo/pull/30999 Signed-off-by: Thomas Bettler <thomas.bettler@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> sci-libs/pdal/files/pdal-2.4.3-fix-gcc13.patch | 29 ++++++++++++ sci-libs/pdal/files/pdal-2.4.3-fix-gdal37.patch | 37 +++++++++++++++ sci-libs/pdal/pdal-2.4.3-r1.ebuild | 63 +++++++++++++++++++++++++ sci-libs/pdal/pdal-2.5.3-r1.ebuild | 61 ++++++++++++++++++++++++ 4 files changed, 190 insertions(+) |