Bug 905605

Summary:	dev-lang/jimtcl-0.81 always use jimsh0 to bootstrap
Product:	Gentoo Linux	Reporter:	Esteve Varela Colominas <esteve.varela>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esteve.varela
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/msteveb/jimtcl/issues/247 https://github.com/gentoo/gentoo/pull/34890 https://bugs.gentoo.org/show_bug.cgi?id=949981
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	847148

Description Esteve Varela Colominas 2023-05-02 19:27:43 UTC

Currently, building dev-lang/jimtcl when it's already installed breaks, with a "*** buffer overflow detected ***: terminated" message.

This is fixed in 0.82[1], but in order to prevent this issue and similar potential issues in the future, I'd consider *always* building a bootstrap shell.

The file "autosetup/autosetup-find-tclsh", first looks for "./jimsh0" before trying the installed shell, and regular tclsh. If it finds none of them, it builds jimsh0 using "$CC_FOR_BUILD -o jimsh0 autosetup/jimsh0.c".

I think replicating this build command in the ebuild would be simple enough.

[1]: https://github.com/msteveb/jimtcl/issues/247

Comment 1 Sam James archtester

2023-05-02 20:06:38 UTC

Perhaps a USE=system-bootstrap instead. But really, this was kind of a specific issue which needed resolving, no?

Comment 2 Esteve Varela Colominas 2024-01-18 20:39:48 UTC

I think having different behavior between a clean install and an upgrade leads to hard to detect bugs like this one. Anyway, I'll be sending a PR in a bit.

Comment 3 Sam James archtester

2025-02-20 14:39:30 UTC

(In reply to Esteve Varela Colominas from comment #2)
> I think having different behavior between a clean install and an upgrade
> leads to hard to detect bugs like this one. Anyway, I'll be sending a PR in
> a bit.

Yes, I changed my mind. Determinism is better.

Comment 4 Sam James archtester

2025-02-20 14:40:30 UTC

commit 888388225a24e021a960694457ea0302dc417a90
Author: Esteve Varela Colominas <esteve.varela@gmail.com>
Date:   Wed Feb 28 17:17:14 2024 +0100

    dev-lang/jimtcl: Bump to 0.82

    Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/34890
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>