Summary: | dev-db/postgis-3.3.2-r1 with bundled flatgeobuf which is bundling flatbuffers, with dev-cpp/abseil-cpp-20230125.2: /usr/include/absl/base/policy_checks.h:79:2: error: #error "C++ versions less than C++14 are not supported." | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Andreas Sturmlechner <asturm> |
Component: | Current packages | Assignee: | PgSQL Bugs <pgsql-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | espinafre, remi2402, sci-geosciences |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=905626 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 905701 | ||
Attachments: |
dev-db:postgis-3.3.2-r1:20230430-152556.log
building postgis-3.3.2-r1 with abseil-2023 |
Description
Andreas Sturmlechner
2023-04-30 15:45:01 UTC
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8b443b69f39a883db7fecda54e216f578c0e0ae6 commit 8b443b69f39a883db7fecda54e216f578c0e0ae6 Author: Patrick Lauer <patrick@gentoo.org> AuthorDate: 2023-05-01 15:19:03 +0000 Commit: Patrick Lauer <patrick@gentoo.org> CommitDate: 2023-05-01 15:19:57 +0000 dev-db/postgis: Add blocker for dev-cpp/abseil-cpp Closes: https://bugs.gentoo.org/905378 Signed-off-by: Patrick Lauer <patrick@gentoo.org> dev-db/postgis/postgis-3.1.3.ebuild | 3 ++- dev-db/postgis/postgis-3.1.8-r1.ebuild | 1 + dev-db/postgis/postgis-3.2.4-r1.ebuild | 1 + dev-db/postgis/postgis-3.3.2-r1.ebuild | 1 + dev-db/postgis/postgis-9999.ebuild | 1 + 5 files changed, 6 insertions(+), 1 deletion(-) That does not look right. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5a74f524709ca1ca6cc43cd627a88ccebad9bd81 commit 5a74f524709ca1ca6cc43cd627a88ccebad9bd81 Author: David Seifert <soap@gentoo.org> AuthorDate: 2023-05-01 15:55:40 +0000 Commit: David Seifert <soap@gentoo.org> CommitDate: 2023-05-01 15:55:40 +0000 Reverts: [QA] 8b443b6 (dev-db/postgis: Add blocker for dev-cpp/abseil-cpp) * Hard blockers are terrible UX and are a sin unto our users. * This is a lazy fix instead of porting the package to a more recent version of C++. Bug: https://bugs.gentoo.org/905378 Signed-off-by: David Seifert <soap@gentoo.org> dev-db/postgis/postgis-3.1.3.ebuild | 3 +-- dev-db/postgis/postgis-3.1.8-r1.ebuild | 1 - dev-db/postgis/postgis-3.2.4-r1.ebuild | 1 - dev-db/postgis/postgis-3.3.2-r1.ebuild | 1 - dev-db/postgis/postgis-9999.ebuild | 1 - 5 files changed, 1 insertion(+), 6 deletions(-) Created attachment 861521 [details, diff]
building postgis-3.3.2-r1 with abseil-2023
This user patch allows postgis-3.3.2-r1 to be built with the latest version of abseil. The C++ standard version must be C++17; I've tried C++14, but the build keeps failing: ---8><--- x86_64-pc-linux-gnu-gcc -std=c++14 -x c++ -I../../liblwgeom -I../../liblwgeom -I./include -I/usr/include -I/usr/include/libxml2 -I/usr/include/json-c -DNDEBUG -march=native -O2 -pipe -fPIC -DPIC -c -o flatgeobuf_c.o flatgeobuf_c.cpp x86_64-pc-linux-gnu-gcc -std=c++14 -x c++ -I../../liblwgeom -I../../liblwgeom -I./include -I/usr/include -I/usr/include/libxml2 -I/usr/include/json-c -DNDEBUG -march=native -O2 -pipe -fPIC -DPIC -c -o geometrywriter.o geometrywriter.cpp x86_64-pc-linux-gnu-gcc -std=c++14 -x c++ -I../../liblwgeom -I../../liblwgeom -I./include -I/usr/include -I/usr/include/libxml2 -I/usr/include/json-c -DNDEBUG -march=native -O2 -pipe -fPIC -DPIC -c -o geometryreader.o geometryreader.cpp x86_64-pc-linux-gnu-gcc -std=c++14 -x c++ -I../../liblwgeom -I../../liblwgeom -I./include -I/usr/include -I/usr/include/libxml2 -I/usr/include/json-c -DNDEBUG -march=native -O2 -pipe -fPIC -DPIC -c -o packedrtree.o packedrtree.cpp make[2]: Entering directory '/var/tmp/portage/dev-db/postgis-3.3.2-r1/work/postgis-3.3.2-15/deps/wagyu' x86_64-pc-linux-gnu-gcc -std=c++14 -x c++ -I../../liblwgeom -I../../liblwgeom -I./include -I/usr/include -I/usr/include/libxml2 -I/usr/include/json-c -DNDEBUG -march=native -O2 -pipe -fPIC -DPIC -c -o lwgeom_wagyu.o lwgeom_wagyu.cpp /usr/bin/perl ../utils/create_undef.pl legacy.sql 150 > uninstall_legacy.sql /usr/bin/perl ../utils/create_undef.pl postgis.sql 150 > uninstall_postgis.sql /usr/bin/perl ../utils/create_upgrade.pl postgis.sql > postgis_upgrade.sql.in echo "BEGIN;" > postgis_upgrade.sql cat postgis_before_upgrade.sql postgis_upgrade.sql.in postgis_after_upgrade.sql >> postgis_upgrade.sql echo "COMMIT;" >> postgis_upgrade.sql In file included from ./include/flatbuffers/base.h:237, from ./include/flatbuffers/array.h:20, from ./include/flatbuffers/flatbuffers.h:22, from feature_generated.h:7, from flatgeobuf_c.cpp:26: /usr/include/absl/strings/string_view.h:52:26: error: 'string_view' in namespace 'std' does not name a type 52 | using string_view = std::string_view; | ^~~~~~~~~~~ /usr/include/absl/strings/string_view.h:52:21: note: 'std::string_view' is only available from C++17 onwards 52 | using string_view = std::string_view; | ^~~ ---8><--- C++17 (which the above patch specifies) does the trick. Works for me, any objections? The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dc10ecae76251e05914bdd47a9728a42ef0cc853 commit dc10ecae76251e05914bdd47a9728a42ef0cc853 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2023-05-29 18:50:28 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2023-05-29 19:09:34 +0000 dev-db/postgis: Fix build with dev-cpp/abseil-cpp-20230125.2 Closes: https://bugs.gentoo.org/905378 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../postgis-3.3.2-flatbuffers-abseil-2023.patch | 39 ++++++++++++++++++++++ dev-db/postgis/postgis-3.3.2-r1.ebuild | 2 ++ 2 files changed, 41 insertions(+) |