Summary: | dev-cpp/gtest-1.13.0: failed (test phase) (x86): 29 - googletest-printers-test (Failed) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Joonas Niilola <juippis> |
Component: | Current packages | Assignee: | Peter Levine <plevine457> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | lockalsash, plevine457, proxy-maint |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/google/googletest/issues/4210 | ||
See Also: | https://github.com/gentoo/gentoo/pull/37191 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
gtest-1.13.0:20230425-121345.log
LastTest.log.xz |
Description
Joonas Niilola
![]() Created attachment 860760 [details]
gtest-1.13.0:20230425-121345.log
Created attachment 860761 [details]
LastTest.log.xz
Excerpt from log: [ RUN ] PrintOptionalTest.Basic /var/tmp/portage/dev-cpp/gtest-1.13.0/work/googletest-1.13.0/googletest/test/googletest-printers-test.cc:1905: Failure Expected equality of these values: "(1.1)" PrintToString(internal::Optional<double>{1.1}) Which is: "(1.1000000000000001)" [ FAILED ] PrintOptionalTest.Basic (0 ms) [ RUN ] PrintBuiltInTypeTest.FloatingPoints /var/tmp/portage/dev-cpp/gtest-1.13.0/work/googletest-1.13.0/googletest/test/googletest-printers-test.cc:465: Failure Expected equality of these values: "1.1" Print(1.10000002f) Which is: "1.10000002" /var/tmp/portage/dev-cpp/gtest-1.13.0/work/googletest-1.13.0/googletest/test/googletest-printers-test.cc:467: Failure Expected equality of these values: "9e+09" Print(9e9f) Which is: "8.99999949e+09" [ FAILED ] PrintBuiltInTypeTest.FloatingPoints (0 ms) Upstream report: https://github.com/google/googletest/issues/4210 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5037161d1847e7b51fac52e304fb120682455d8b commit 5037161d1847e7b51fac52e304fb120682455d8b Author: Peter Levine <plevine457@gmail.com> AuthorDate: 2024-06-18 01:38:20 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-06-18 02:08:52 +0000 dev-cpp/gtest: fix test failure on x86 Testing on x86 architecture causes a unittest to fail due to a floating-point precision discrepancy. Like Debian, we add -ffloat-store until upstream addresses the issue. Closes: https://bugs.gentoo.org/905007 Closes: https://github.com/gentoo/gentoo/pull/37191 Suggested-by: Sam James <sam@gentoo.org> Signed-off-by: Peter Levine <plevine457@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-cpp/gtest/gtest-1.14.0-r1.ebuild | 7 ++++++- dev-cpp/gtest/gtest-9999.ebuild | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) |