| Summary: | net-dialup/rp-pppoe: build failure with net-dialup/ppp-2.5.0 (plugin.c: error: VERSION undeclared here (not in a function)) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Sam James <sam> |
| Component: | Current packages | Assignee: | Jaco Kroon <jaco> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ago, Letto2, proxy-maint, toralf |
| Priority: | Normal | Keywords: | PATCH, PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/30968 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 904841 | ||
|
Description
Sam James
2023-04-23 04:54:38 UTC
*** Bug 904858 has been marked as a duplicate of this bug. *** *** Bug 904863 has been marked as a duplicate of this bug. *** (In reply to Sam James from comment #0) > Patch at > https://salsa.debian.org/dskoll/rp-pppoe/-/commit/ > e8abb8e6e5851407ac8ff9a29afa683a0d1182d0, but maybe we should just bump to > 4.0-beta1 instead. Upstream also recomends that: Note: rp-pppoe 3.15 does not compile against PPP version >= 2.5.0. If you are using PPP >= 2.5.0, please try rp-pppoe-4.0-beta1 below instead. Hi yes, a bump is required, I can action over the weekend. My suggestion would be to keep the existing version as stable for now, but update the dependency on ppp to be <2.5.0 - if that's OK I'll make it part of the same PR? Sorry for the delay here, been on holiday for the latter part of April. Just sorting out some "put bread on the table" type work in the week. As a side note: the beta contains a lot of fairly experimental code and large deviations with more changes to follow which I've got planned but having trouble finding the time to cook (and need in the medium to longer term), so I would highly recommend against people blindly upgrading. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=de8128f7841a3f2a3f9c4033993f272f244e6785 commit de8128f7841a3f2a3f9c4033993f272f244e6785 Author: Jaco Kroon <jaco@uls.co.za> AuthorDate: 2023-05-10 09:57:12 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-05-10 19:39:29 +0000 net-dialup/rp-pppoe: add 4.0 Closes: https://bugs.gentoo.org/730554 Closes: https://bugs.gentoo.org/872371 Closes: https://bugs.gentoo.org/904847 Signed-off-by: Jaco Kroon <jaco@uls.co.za> Closes: https://github.com/gentoo/gentoo/pull/30968 Signed-off-by: Sam James <sam@gentoo.org> net-dialup/rp-pppoe/Manifest | 1 + net-dialup/rp-pppoe/rp-pppoe-4.0.ebuild | 76 +++++++++++++++++++++++++++++++++ 2 files changed, 77 insertions(+) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4c6a68871ea79c81d0165203b49194e82e48e2d1 commit 4c6a68871ea79c81d0165203b49194e82e48e2d1 Author: Jaco Kroon <jaco@uls.co.za> AuthorDate: 2023-05-10 09:48:23 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-05-10 19:39:27 +0000 net-dialup/rp-pppoe: 3.15 - restrict ppp version. Bug: https://bugs.gentoo.org/904847 Signed-off-by: Jaco Kroon <jaco@uls.co.za> Signed-off-by: Sam James <sam@gentoo.org> net-dialup/rp-pppoe/rp-pppoe-3.15-r2.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |