Bug 904756

Summary:	www-client/firefox: Allow users to disable telemetry in build time
Product:	Gentoo Linux	Reporter:	Morteza <mr.oneacer>
Component:	Current packages	Assignee:	Mozilla Gentoo Team <mozilla>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gentoo
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=685196
Whiteboard:
Package list:		Runtime testing required:	---

Description Morteza 2023-04-21 21:18:29 UTC

I compared with librewolf ebuild and found out it has disabled telemetry by default, so maybe having a telemetry use flag is not a bad idea?
where telemery is disabled in librewolf: https://gitlab.com/librewolf-community/browser/gentoo/-/blob/master/www-client/librewolf/librewolf-112.0.1_p2.ebuild#L792

Reproducible: Always

Comment 1 Joonas Niilola gentoo-dev

2023-04-22 06:35:38 UTC

I vaguely remember this being tied to some core functionality, as kurly also pointed out by linking that old bug, but will need to see what exactly gets disabled with that flag.

Comment 2 Larry the Git Cow gentoo-dev

2023-04-23 14:20:47 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6df3faf82239bb42832e1057188b5204be986415

commit 6df3faf82239bb42832e1057188b5204be986415
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2023-04-23 14:10:31 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-04-23 14:20:14 +0000

    www-client/firefox: bug fixes for 112.0.1
    
     - add error-state returning to virtwl(),
     - allow disabling telemetry via an USE flag,
     - include an upstream patch to fix weird bitmap font behaviour
       (upstream bug #1827950).
    
    Bug: https://bugs.gentoo.org/904354
    Closes: https://bugs.gentoo.org/904756
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/Manifest               |  2 +-
 www-client/firefox/firefox-112.0.1.ebuild | 17 ++++++++++++++---
 2 files changed, 15 insertions(+), 4 deletions(-)

Comment 3 Sam James archtester

2023-04-25 02:20:32 UTC

Additional context:

commit 1dcdc2649f0478c4b35ab4200c797e50ca6be69e
Author: Joonas Niilola <juippis@gentoo.org>
Date:   Mon Apr 24 08:20:19 2023 +0300

    www-client/firefox: default-enable telemetry, as intended by upstream

    Signed-off-by: Joonas Niilola <juippis@gentoo.org>