Bug 904266

Summary:	media-gfx/flameshot: missing kde-frameworks/kguiaddons depend when using wayland
Product:	Gentoo Linux	Reporter:	vowstar <vowstar>
Component:	Current packages	Assignee:	Pavel Kalugin <paul.kalug>
Status:	RESOLVED FIXED
Severity:	normal	CC:	asturm, jstein, proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/30580 https://github.com/gentoo/gentoo/pull/30646
Whiteboard:
Package list:		Runtime testing required:	---

Description vowstar 2023-04-13 09:55:35 UTC

As https://github.com/flameshot-org/flameshot/pull/2284,
kde-frameworks/kguiaddons should be a depend when using wayland.
If this is missing, it will cause incorrect clipboard behavior.

Reproducible: Always

Steps to Reproduce:
1. Setup gnome wayland environment
2. Install media-gfx/flameshot
3. Take a screenshot
Actual Results:  
Clipboard behavior was incorrect, screenshot results could not be pasted correctly in most cases

Expected Results:  
The clipboard behaves correctly


DEPEND with wayland? ( kde-frameworks/kguiaddons ) and
	local mycmakeargs=(
		-DUSE_EXTERNAL_SINGLEAPPLICATION=1
		-DENABLE_CACHE=0
		-DUSE_WAYLAND_CLIPBOARD=$(usex wayland)
	)

This way the clipboard behaves correctly.

Comment 1 Larry the Git Cow gentoo-dev

2023-04-14 01:06:07 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9474805514651c85628be780897a6317804d9716

commit 9474805514651c85628be780897a6317804d9716
Author:     Huang Rui <vowstar@gmail.com>
AuthorDate: 2023-04-13 10:00:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-14 01:05:20 +0000

    media-gfx/flameshot: fix wayland clipboard behavior
    
    Closes: https://bugs.gentoo.org/904266
    Signed-off-by: Huang Rui <vowstar@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../{flameshot-12.1.0.ebuild => flameshot-12.1.0-r1.ebuild}   | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

Comment 2 Andreas Sturmlechner gentoo-dev

2023-04-18 11:13:25 UTC

You must depend on kde-frameworks/kguiaddons:5 or otherwise this will fail right again once kguiaddons:6 comes around.

Comment 3 vowstar 2023-04-19 02:39:02 UTC

(In reply to Andreas Sturmlechner from comment #2)
> You must depend on kde-frameworks/kguiaddons:5 or otherwise this will fail
> right again once kguiaddons:6 comes around.

Done, fixed in https://github.com/gentoo/gentoo/pull/30646

Comment 4 Larry the Git Cow gentoo-dev

2023-04-26 04:03:34 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1bca85e2acf03e9d8870a86feafdeeb5245eb658

commit 1bca85e2acf03e9d8870a86feafdeeb5245eb658
Author:     Huang Rui <vowstar@gmail.com>
AuthorDate: 2023-04-19 02:26:42 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-26 04:02:54 +0000

    media-gfx/flameshot: depend on kde-frameworks/kguiaddons:5
    
    Depend on kde-frameworks/kguiaddons:5 or otherwise this will fail
    right again once kguiaddons:6 comes around.
    
    Bug: https://bugs.gentoo.org/904266
    Signed-off-by: Huang Rui <vowstar@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/30646
    Signed-off-by: Sam James <sam@gentoo.org>

 .../{flameshot-12.0.0-r1.ebuild => flameshot-12.0.0-r2.ebuild}          | 2 +-
 .../{flameshot-12.1.0-r1.ebuild => flameshot-12.1.0-r2.ebuild}          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)