Bug 904087

Summary:	sys-fs/zfs-kmod should not always require CONFIG_MODULES
Product:	Gentoo Linux	Reporter:	Justus Ranvier <gentoobugs.starch836>
Component:	Current packages	Assignee:	Sam James <sam>
Status:	CONFIRMED ---
Severity:	enhancement	CC:	gentoo, sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://wiki.gentoo.org/wiki/ZFS#Installing_into_the_kernel_directory_.28for_static_installs.29
Whiteboard:
Package list:		Runtime testing required:	---

Description Justus Ranvier 2023-04-10 01:20:19 UTC

The instructions on the wiki for installing zfs into the kernel source requires one to run the configure step of the ebuild only without actually installing the package.

This will fail unless CONFIG_MODULES=y is set in the kernel source directory, however this may be completely unnecessary because one of the reasons to copy the driver into the kernel source is precisely to enable the use of zfs with a non-modular kernel.

Ideally this check would be behind a USE flag which could be turned off for users who only need to to use the copy-builtin script. Since sys-fs/zfs uses the kernel-builtin flag for this scenario it would make sense for that flag to also apply to sys-fs/zfs-kmod and if set disable the check for CONFIG_MODULES=y.

Reproducible: Always

Comment 1 Georgy Yakovlev archtester

2023-04-17 20:40:40 UTC

Flag would be overkill for it, we can simply do this instead:

has '--enable-linux-builtin' ${EXTRA_ECONF} || CONFIG_CHECK+=" MODULES"

I'll test it a bit and will add something later.