Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 90176

Summary: xine-lib -1.0-r3 links to vcdimager without a dependency
Product: Gentoo Linux Reporter: Spider (RETIRED) <spider>
Component: Current packagesAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---

Description Spider (RETIRED) gentoo-dev 2005-04-23 15:46:23 UTC
appears to be linked to the --enable-vcd flag, here's a patch that works, but breaks repoman (  vcdimager isn't avaiable on ~arm and ~hppa  )

Otherwise, its a trivial fix :
--- xine-lib-1.0-r3.ebuild      2005-04-22 19:21:20.000000000 +0200
+++ xine-lib-1.0-r4.ebuild      2005-04-24 00:42:55.000000000 +0200
@@ -38,6 +38,7 @@
        png? ( media-libs/libpng )
        mng? ( media-libs/libmng )
        ffmpeg? ( >=media-video/ffmpeg-0.4.9_p20050226-r1 )
+       vcd? ( media-video/vcdimager )
        !=media-libs/xine-lib-0.9.13*"
 DEPEND="${RDEPEND}
        v4l? ( sys-kernel/linux-headers )
@@ -220,6 +221,7 @@
                $(use_enable alsa) \
                $(use_enable arts) \
                $(use_enable esd) \
+               $(use_enable vcd) \
                ${myconf} \
                --disable-dependency-tracking || die "Configure failed"
Comment 1 Spider (RETIRED) gentoo-dev 2005-04-23 16:01:56 UTC
ahh, of course and sorry, IUSE needs to be appended with "vcd" as well.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-23 16:28:19 UTC
Thanks but as vcdimager is missing on hppa and arm, I hope those can add it to testing before I apply the patch, else I need to blacklist it in the ebuild.

If vcdimager can't work on those systems (or it's not supposed to), I think they can usemask vcd.
Comment 3 Spider (RETIRED) gentoo-dev 2005-04-23 16:35:18 UTC
well, the problem right now is this :
ldd /usr/lib/xine/plugins/1.0.0/xineplug_inp_vcd.so
        libvcdinfo.so.0 => /usr/lib/libvcdinfo.so.0 (0xb7f5f000)
        libiso9660.so.4 => /usr/lib/libiso9660.so.4 (0xb7f53000)
        libcdio.so.5 => /usr/lib/libcdio.so.5 (0xb7f35000)


So basically it currently links to the files without telling.   I believe that xine-lib has an internal version of it as well though ( the configure hinted at it at least )
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-23 16:42:54 UTC
There is an internal copy but I don't think is safe relying on that as it's just a vcdimager copy, and if vcdimager is untested on those archs, also the internal copy is untested. Also, usually xine uses the internal copy for everything instead of relying on the external one, but this is not the case so I don't trust it at all.

As xine uses plugins to manage things, this imply that the dependency, also if cohercely built, is not "hard", as removing vcdimager just disables the vcd plugin, so the problem is not too big, imho, and can wait until we have better news from arm and hppa herds.
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-23 19:23:03 UTC
I'm going to fix this with an -r4 in the next days adding also the wma lossless support and a cleanup of xine's doc files. Moving Priority to 3 as it's not an urgent thing anyway.
Comment 6 SpanKY gentoo-dev 2005-04-24 02:46:04 UTC
arm/hppa now KEYWORDed
Comment 7 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-24 12:44:17 UTC
Fixed in -r4, dependency is still "automagical" for older revisions as it doesn't break the binary if vcdimager is removed.