Bug 899564

Summary:	media-sound/mixxx-2.3.6-r2 adds -Werror flag on its own
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Professional Audio Applications Maintainers <proaudio>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, fordfrog, parona
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/40226
Whiteboard:	fixed in 2.5.0
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867, 949928
Attachments:	build.log.xz

Description Agostino Sarubbo gentoo-dev

2023-03-04 08:58:20 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-sound/mixxx-2.3.4 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

Comment 1 Agostino Sarubbo gentoo-dev

2023-03-04 08:58:22 UTC

Created attachment 856068 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

Comment 2 Agostino Sarubbo gentoo-dev

2023-05-11 06:32:35 UTC

ci has reproduced this issue with version 2.3.5 - Updating summary.

Comment 3 Agostino Sarubbo gentoo-dev

2023-05-31 08:08:01 UTC

ci has reproduced this issue with version 2.3.5-r1 - Updating summary.

Comment 4 Agostino Sarubbo gentoo-dev

2023-08-16 15:25:11 UTC

ci has reproduced this issue with version 2.3.6 - Updating summary.

Comment 5 Agostino Sarubbo gentoo-dev

2024-12-28 09:21:46 UTC

ci has reproduced this issue with version 2.3.6-r1 - Updating summary.

Comment 6 Alfred Wingate 2025-01-21 22:48:25 UTC

The -Werror came from vendored benchmark, this has been removed since 2.4.0.

https://github.com/mixxxdj/mixxx/commit/57fcb1db958b160860184f78376334b0b6243fe3

Comment 7 Agostino Sarubbo gentoo-dev

2025-01-31 10:44:28 UTC

ci has reproduced this issue with version 2.3.6-r2 - Updating summary.

Comment 8 Larry the Git Cow gentoo-dev

2025-02-10 20:42:21 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=539b05c45b2d0f5800ae69e2e0865e0b9dd64d30

commit 539b05c45b2d0f5800ae69e2e0865e0b9dd64d30
Author:     Nicolas PARLANT <nicolas.parlant@parhuet.fr>
AuthorDate: 2025-01-21 16:41:39 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-02-10 20:41:50 +0000

    media-sound/mixxx: add 2.5.0
    
    sync with live
    patch for tests/benchmark
    
    Bug: https://bugs.gentoo.org/899564
    Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
    Closes: https://github.com/gentoo/gentoo/pull/40226
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-sound/mixxx/Manifest                      |   1 +
 media-sound/mixxx/files/mixxx-2.5.0-tests.patch | 444 ++++++++++++++++++++++++
 media-sound/mixxx/mixxx-2.5.0.ebuild            | 172 +++++++++
 3 files changed, 617 insertions(+)