Bug 89945

Summary:	mozilla-firefox builds a firefox with generic blue icon instead of red & blue logo
Product:	Gentoo Linux	Reporter:	Ben Kohler <bjk4hf>
Component:	Current packages	Assignee:	Mozilla Gentoo Team <mozilla>
Status:	RESOLVED DUPLICATE
Severity:	trivial	CC:	hugues.fournier, mikevalstar, steev
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://forums.gentoo.org/viewtopic-t-327029.html
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	ebuild fixed to use real firefox icons ebuild with artwork useflag to use the firefox artwork patch using mozconfig_use_enable against mozilla-firefox-1.0.4.ebuild version 1.4

Description Ben Kohler 2005-04-21 10:44:03 UTC

Emerging mozilla-firefox gives you a firefox with a generic-looking blue globe icon in the taskbar and in the "about" dialog.  However, emerging mozilla-firefox-bin gives you a firefox with the familiar orange/blue firefox icon that we all know and love.

Reproducible: Always
Steps to Reproduce:
1.  run "emerge mozilla-firefox"
2.  run "firefox"

Actual Results:  
The icon in the taskbar of xfce/gnome/kde/etc is a blue one rather than the
orange/blue logo.  It is also a big blue globe in the "about" dialog rather than
a big pretty firefox logo.

Expected Results:  
The normal firefox icon should show whether you build from source or use the binary.

Comment 1 Ben Kohler 2005-04-21 10:46:30 UTC

Created attachment 56854 [details]
ebuild fixed to use real firefox icons

added lines are 61-65, found at the end of the src_unpack section

Comment 2 Steev Klimaszewski (RETIRED) gentoo-dev

2005-05-09 16:17:30 UTC

Created attachment 58530 [details]
ebuild with artwork useflag to use the firefox artwork

This adds a useflag of "artwork" to the ebuild, allowing you to USE="artwork"
emerge mozilla-firefox and it will use the artwork, otherwise, it continues to
build it with the wonderful blue globe :)

Comment 3 Hugues Fournier 2005-05-12 08:38:08 UTC

Created attachment 58755 [details, diff]
patch using mozconfig_use_enable against mozilla-firefox-1.0.4.ebuild version 1.4

This is a patch against mozilla-firefox-1.0.4.ebuild revision 1.4 ebuild with
IMHO the right way to do it using mozconfig_use_enable.
Indeed Firefox and Thunderbird have an compilation option
--enable-official-branding that cleanly does what was done in the previous
suggested ebuild with some 'cp'
The same simple change could be done in Thunderbird.

Comment 4 deathlove 2005-08-14 06:22:43 UTC

Hello,

please do not forget added this "--enable-official-branding" to portage

thx

Comment 5 Jakub Moc (RETIRED) gentoo-dev

2005-12-22 20:37:25 UTC

Branding is unfortunately not that easy as one patch (legal issues)...

*** This bug has been marked as a duplicate of 113971 ***