Bug 898888

Summary:	x11-misc/piedock-1.6.9 fails to compile (MUSL-CLANG-SYSTEM): WildcardCompare.cpp:94:5: error: ISO C++17 does not allow register storage class specifier [-Wregister]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/31328
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-03-02 10:06:41 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-misc/piedock-1.6.9 fails to compile (MUSL-CLANG-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-CLANG-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc + clang16 but this bug MAY or MAY NOT BE related to musl/clang16.

Comment 1 Agostino Sarubbo gentoo-dev

2023-03-02 10:06:43 UTC

Created attachment 855762 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2023-06-17 14:23:53 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=29078f3a48e0ec0f8703614bf90c7e0290ce0de9

commit 29078f3a48e0ec0f8703614bf90c7e0290ce0de9
Author:     Brahmajit Das <brahmajit.xyz@gmail.com>
AuthorDate: 2023-06-06 17:20:09 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-06-17 14:23:50 +0000

    x11-misc/piedock: -Wregister fix
    
    ISO C++17 does not allow register storage class specifier
    
    Also fixes non-constant-expression cannot be narrowed
    
    Closes: https://bugs.gentoo.org/898888
    Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/31328
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../piedock-1.6.9-clang16-register-narrowing.diff  | 108 +++++++++++++++++++++
 ...iedock-1.6.9.ebuild => piedock-1.6.9-r1.ebuild} |   5 +-
 2 files changed, 111 insertions(+), 2 deletions(-)