Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 898156

Summary: net-print/cups-filters-1.28.17 build failed with >=app-text/qpdf-11.3.0 (error: ‘std::string_view’ has not been declared)
Product: Gentoo Linux Reporter: ArchFeh(Yu Gu) <guyu2876>
Component: Current packagesAssignee: Printing Team <printing>
Status: RESOLVED FIXED    
Severity: normal Keywords: PullRequest
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/29831
https://github.com/OpenPrinting/cups-filters/issues/512
https://bugs.gentoo.org/show_bug.cgi?id=898076
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: build.log

Description ArchFeh(Yu Gu) 2023-02-27 13:23:20 UTC
Created attachment 855020 [details]
build.log

/usr/include/qpdf/QPDFWriter.hh:560:32: error: ‘std::string_view’ has not been declared

std::string_view was introduced in c++17, and the ebuild was compiled with c++11, so the error occurs. I will raise a pr.
Comment 1 Larry the Git Cow gentoo-dev 2023-02-27 22:30:48 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=67821b27fe794c645040025594950eac26fd9e3c

commit 67821b27fe794c645040025594950eac26fd9e3c
Author:     Yu Gu <guyu2876@gmail.com>
AuthorDate: 2023-02-27 13:29:01 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-27 22:30:28 +0000

    net-print/cups-filters: fix compile failure
    
    /usr/include/qpdf/QPDFWriter.hh:560:32: error: ‘std::string_view’ has not been declared
    std::string_view was introduced in c++17, and the ebuild was compiled with c++11, so the error occurs.
    
    Bug: https://bugs.gentoo.org/898156
    Signed-off-by: Yu Gu <guyu2876@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/29831
    Signed-off-by: Sam James <sam@gentoo.org>

 .../cups-filters/cups-filters-1.28.17-r1.ebuild    | 145 +++++++++++++++++++++
 1 file changed, 145 insertions(+)
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-27 22:30:53 UTC
Can you send something upstream too please? Thanks!

Either qpdf needs to indicate this in its pkgconfig file & cmake files, or cups-filters needs to respect the settings qpdf is exposing.
Comment 3 ArchFeh(Yu Gu) 2023-02-28 08:10:12 UTC
(In reply to Sam James from comment #2)
> Can you send something upstream too please? Thanks!
> 
> Either qpdf needs to indicate this in its pkgconfig file & cmake files, or
> cups-filters needs to respect the settings qpdf is exposing.

Sure. I added the issue on see also
Comment 4 psh0r 2023-03-14 22:32:44 UTC
This fix breaks the build for clang profile, see bug 901243