Bug 897796

Summary:	media-sound/sidplay-2.0.9-r1 fails to compile (MUSL-CLANG-SYSTEM): keyboard.cpp:132:5: error: ISO C++17 does not allow register storage class specifier [-Wregister]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo Sound Team <sound>
Status:	RESOLVED FIXED
Severity:	normal	CC:	treecleaner
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/32588
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-02-26 07:47:53 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-sound/sidplay-2.0.9-r1 fails to compile (MUSL-CLANG-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-CLANG-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc + clang16 but this bug MAY or MAY NOT BE related to musl/clang16.

Comment 1 Agostino Sarubbo gentoo-dev

2023-02-26 07:47:55 UTC

Created attachment 854696 [details]
build.log

build log and emerge --info

Comment 2 Sam James archtester

2023-05-11 03:07:23 UTC

Can't even autoreconf because of missing macros.

Comment 3 Larry the Git Cow gentoo-dev

2023-09-04 07:09:25 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=015f3412a0e7534a2ea1410cc278d148c104029e

commit 015f3412a0e7534a2ea1410cc278d148c104029e
Author:     Brahmajit Das <brahmajit.xyz@gmail.com>
AuthorDate: 2023-09-03 18:33:34 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2023-09-04 07:09:20 +0000

    media-sound/sidplay: Fix C++17 does not allow register storage class
    
    Closes: https://bugs.gentoo.org/897796
    Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/32588
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../sidplay-2.0.9-drop-register-keyword.patch      | 16 +++++++++++++++
 media-sound/sidplay/sidplay-2.0.9-r2.ebuild        | 23 ++++++++++++++++++++++
 2 files changed, 39 insertions(+)