Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 896076

Summary: dev-libs/rocm-opencl-runtime-5.4.3 - media-libs/glew should be optional with test?
Product: Gentoo Linux Reporter: Chris Mayo <aklhfex>
Component: Current packagesAssignee: Craig Andrews <candrews>
Status: RESOLVED FIXED    
Severity: normal CC: xgreenlandforwyy
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/30790
Whiteboard:
Package list:
Runtime testing required: ---

Description Chris Mayo 2023-02-23 19:29:16 UTC 
GLEW is only used by tests:

ROCm-OpenCL-Runtime-rocm-5.4.3 $ grep -ril glew
tests/ocltst/module/runtime/CMakeLists.txt
tests/ocltst/module/perf/CMakeLists.txt
tests/ocltst/module/gl/CMakeLists.txt
tests/ocltst/module/common/OCLGLCommonWindows.cpp
tests/ocltst/module/common/OCLGLCommonLinux.cpp
tests/ocltst/module/common/OCLGLCommon.h
tests/ocltst/module/common/CMakeLists.txt
tests/ocltst/CMakeLists.txt


ebuild has:

BDEPEND=">=dev-util/rocm-cmake-5.3
	media-libs/glew
	test? ( >=x11-apps/mesa-progs-8.5.0[X] )
	"
Comment 1 Larry the Git Cow gentoo-dev 2023-07-05 18:22:40 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8b13e5dff1d0d2271fcb1c9556f5ec422d1e7203

commit 8b13e5dff1d0d2271fcb1c9556f5ec422d1e7203
Author:     Yiyang Wu <xgreenlandforwyy@gmail.com>
AuthorDate: 2023-04-28 12:46:03 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2023-07-05 18:22:33 +0000

    dev-libs/rocm-opencl-runtime: glew as test-only DEPEND
    
    Closes: https://bugs.gentoo.org/896076
    Suggested-by: Chris Mayo <aklhfex@gmail.com>
    Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 ...ncl-runtime-5.4.3.ebuild => rocm-opencl-runtime-5.4.3-r1.ebuild} | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)