| Summary: | dev-python/python-dotenv-0.21.1 fails tests | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
| Component: | Current packages | Assignee: | Sebastian Pipping <sping> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ahudson.news, mgorny, python |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/theskumar/python-dotenv/issues/450 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 729958 | ||
| Bug Blocks: | |||
| Attachments: | build.log | ||
|
Description
Agostino Sarubbo
2023-02-23 08:09:57 UTC
Created attachment 854046 [details]
build.log
build log and emerge --info
Error(s) that match a know pattern: FAILED tests/test_cli.py::test_get_default_path - sh.ErrorReturnCode_100: FAILED tests/test_cli.py::test_run - sh.ErrorReturnCode_100: FAILED tests/test_cli.py::test_run_with_existing_variable_not_overridden - sh... FAILED tests/test_cli.py::test_run_with_existing_variable - sh.ErrorReturnCod... FAILED tests/test_cli.py::test_run_with_none_value - sh.ErrorReturnCode_100: SKIPPED [1] tests/test_ipython.py:7: could not import 'IPython': No module named 'IPython' The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5652fe5da6e7021ff52369db0292275b1e9f51b3 commit 5652fe5da6e7021ff52369db0292275b1e9f51b3 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2023-02-23 13:18:31 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2023-02-23 15:14:42 +0000 dev-python/python-dotenv: Depend on dev-python/sh < 2 Bug: https://bugs.gentoo.org/895970 Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-python/python-dotenv/python-dotenv-0.21.1.ebuild | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=42fba663ea2b060cda329e088dc705f0782fb18a commit 42fba663ea2b060cda329e088dc705f0782fb18a Author: Sebastian Pipping <sping@gentoo.org> AuthorDate: 2023-02-23 15:15:55 +0000 Commit: Sebastian Pipping <sping@gentoo.org> CommitDate: 2023-02-23 15:17:08 +0000 dev-python/python-dotenv: Fix test dependencies Bug: https://bugs.gentoo.org/895970 Signed-off-by: Sebastian Pipping <sping@gentoo.org> .../python-dotenv/python-dotenv-0.21.1-r1.ebuild | 44 ++++++++++++++++++++++ 1 file changed, 44 insertions(+) @mgory, it seems like we clashed in Git here, I didn't see it because you were working in -r0 while I was in -r1. I dropped pypy3 now for -r1 for ipython because… REQUIRED_USE="python_targets_pypy3? ( !test )" …was no practical option. Happy to discuss alternatives. Maybe a use flag mask could work? How would you like use to go proceed? PS: How about:
PYTHON_COMPAT=( pypy3 python3_{9..11} )
$(python_gen_any_dep 'dev-python/ipython[${PYTHON_USEDEP}]' 'python3*')
REQUIRED_USE="python_targets_pypy3? ( !test )"
together? Would that work to get pypy3 support back for USE=-test ?
Can't a subset of tests be run without ipython? Don't do REQUIRED_USE, that will only cause mayhem for no gain. (In reply to Michał Górny from comment #7) > Can't a subset of tests be run without ipython? Maybe. Could could mean that this question needs to be answered again for every bump to the package. Maybe we should take some way to bypass these tests upstream then, some global switch. > Don't do REQUIRED_USE, that > will only cause mayhem for no gain. What kind of mayhem? The potential gain could be to give users pypy3 back before bug #729958 is implemented, if that is considered of value. Usually EPYTEST_DESELECT is good enough. Uninstall ipython, get it running, add has_version "dev-python/ipython[${PYTHON_USEDEP}]" && EPYTEST_DESELECT+=. For future version bumps, we can worry when someone reports a test failure.
Fixed by commit 8d3bd924d26cc42008d18bba2aa53153ae4e09f6 in the meantime, closing. Found this report from a month ago after running into issues with the dotenv-1.0 upgrade having been rolled out, which ends up trying to install ipython on my system (which wouldn't be an issue, except ipython also wants to pull in _all_ the dvipng/gtk+/harfbuzz/... dependencies one never knew existed). So I was just wondering: @mgorny mentioned in #c7 keeping the ability to run some tests without ipython if it is not yet installed. I assume this idea has been dropped? To speak for myself, cutting tests down to some subset is not worth developer time and/or the complexity, in my book. Please either run all tests with all dependencies or don't. It may well be possible to cut away some of the dependency tree by adjusting USE flags further down/up the line. Thanks for your understanding. |
