Bug 895880

Summary:	media-libs/libmodplug-0.8.9.0-r1 fails to compile (MUSL-CLANG-SYSTEM): fastmix.cpp:678:2: error: ISO C++17 does not allow register storage class specifier [-Wregister]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo Sound Team <sound>
Status:	RESOLVED FIXED
Severity:	normal	CC:	fordfrog
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-02-22 14:00:08 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/libmodplug-0.8.9.0-r1 fails to compile (MUSL-CLANG-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-CLANG-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc + clang16 but this bug MAY or MAY NOT BE related to musl/clang16.

Comment 1 Agostino Sarubbo gentoo-dev

2023-02-22 14:00:11 UTC

Created attachment 853904 [details]
build.log

build log and emerge --info

Comment 2 Miroslav Šulc gentoo-dev

2023-04-05 11:06:55 UTC

is 0.8.9.1 still affected?

Comment 3 Larry the Git Cow gentoo-dev

2023-04-06 07:18:56 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=08a84b9162c94152fe5c8a08178b8050f31d882c

commit 08a84b9162c94152fe5c8a08178b8050f31d882c
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2023-04-06 07:18:43 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2023-04-06 07:18:43 +0000

    media-libs/libmodplug: dropped obsolete 0.8.9.0-r1 + scrubbed patches
    
    Bug: https://bugs.gentoo.org/903864
    Bug: https://bugs.gentoo.org/895880
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-libs/libmodplug/Manifest                     |  1 -
 .../files/libmodplug-0.8.4-timidity-patches.patch  | 15 ----------
 .../files/libmodplug-0.8.9.0-no-fast-math.patch    |  5 ++--
 .../files/libmodplug-0.8.9.1-timidity.patch        |  2 --
 media-libs/libmodplug/libmodplug-0.8.9.0-r1.ebuild | 35 ----------------------
 5 files changed, 2 insertions(+), 56 deletions(-)

Comment 4 Brahmajit Das 2023-10-24 14:01:47 UTC

(In reply to Larry the Git Cow from comment #3)
Since it's fixed, can we close this bug?

Comment 5 Miroslav Šulc gentoo-dev

2023-10-24 14:04:35 UTC

(In reply to listout from comment #4)
> (In reply to Larry the Git Cow from comment #3)
> Since it's fixed, can we close this bug?

ah, i didn't have feedback so far whether the issue is fixed. thanks. closing the bug.