Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 895722

Summary: x11-wm/qtile should have constraint for dev-python/pywlroots 0.15.x
Product: Gentoo Linux Reporter: Bartek Stalewski <ftpd+sites>
Component: Current packagesAssignee: Egor Martynov <martynovegorOF>
Status: RESOLVED FIXED    
Severity: critical CC: proxy-maint
Priority: Highest Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/29744
https://github.com/qtile/qtile/pull/3985
Whiteboard:
Package list:
Runtime testing required: ---

Description Bartek Stalewski 2023-02-21 13:45:39 UTC
After bumping dev-python/pywlroots to 0.16.0 in https://github.com/gentoo-mirror/gentoo/commit/7f9f108587e73fe1000a623900abc38285dc9fb8, qtile window manager can't build anymore, because it relies on version >0.15.1, but <0.16.x.

Please add this constraint for current ebuilds. It should be lifted when https://github.com/qtile/qtile/pull/3985 is merged.

Reproducible: Always

Steps to Reproduce:
1.upgrade pywlroots to 0.16.0
2.emerge x11-wm/qtile
Actual Results:  
qtile build crashed. I can provide build log, sure, but it doesn't make sense, as we already know the reason - current qtile can't work with pywlroots 0.16.0 yet.
Comment 1 Egor Martynov 2023-02-23 03:01:39 UTC
(In reply to Bartek Stalewski from comment #0)
> After bumping dev-python/pywlroots to 0.16.0 in
> https://github.com/gentoo-mirror/gentoo/commit/
> 7f9f108587e73fe1000a623900abc38285dc9fb8, qtile window manager can't build
> anymore, because it relies on version >0.15.1, but <0.16.x.
> 
> Please add this constraint for current ebuilds. It should be lifted when
> https://github.com/qtile/qtile/pull/3985 is merged.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1.upgrade pywlroots to 0.16.0
> 2.emerge x11-wm/qtile
> Actual Results:  
> qtile build crashed. I can provide build log, sure, but it doesn't make
> sense, as we already know the reason - current qtile can't work with
> pywlroots 0.16.0 yet.

Thank you! I am subscribed to that PR, and I will push the changes after it will be merged.
Comment 2 Egor Martynov 2023-02-23 03:08:24 UTC
We can elevate pywlroots version only on 9999 ebuild, because for stable releases, we will need to wait for the next release of Qtile, where 0.16.0 version is supported.
Comment 3 Bartek Stalewski 2023-02-23 09:28:44 UTC
But shouldn't you add this restriction/hard depend on 0.15 for all existing ebuilds? Now simple `emerge qtile` from scratch will fail for anyone, because it will pull wlroots 0.16, the current latest version in Portage. This bug is all about preventing it.

Sure, in the future when 0.16 PR will be merged, the restriction should be lifted from 9999 ebuild (and all newer official releases in the future), but now I still suggest adding it to every ebuild, 9999 included.
Comment 4 Larry the Git Cow gentoo-dev 2023-02-23 13:40:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dff5e674d0b9e0875bb80773178e4b70738dbcb3

commit dff5e674d0b9e0875bb80773178e4b70738dbcb3
Author:     Egor Martynov <martynovegorOF@yandex.ru>
AuthorDate: 2023-02-23 10:45:35 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-23 13:40:17 +0000

    x11-wm/qtile: depend on pywlroots-0.15.x versions
    
    Bug: https://github.com/qtile/qtile/pull/3985
    Closes: https://bugs.gentoo.org/895722
    Signed-off-by: Egor Martynov <martynovegorOF@yandex.ru>
    Signed-off-by: Sam James <sam@gentoo.org>

 x11-wm/qtile/qtile-0.22.1-r1.ebuild | 4 +++-
 x11-wm/qtile/qtile-9999.ebuild      | 8 +++++---
 2 files changed, 8 insertions(+), 4 deletions(-)