Summary: | sys-libs/minizip-ng-3.0.8 - tries to find_dependency(ZLIBNG) but sys-libs/zlib-ng doesn't install cmake files | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Bernd <waebbl-gentoo> |
Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | UNCONFIRMED --- | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 895714 |
Description
Bernd
2023-02-19 19:53:55 UTC
I'd appreciate it if you could take a look at fixing zlib-ng, it's kind of a mess overall. Could it be the issue is related to https://github.com/zlib-ng/minizip-ng/blob/master/CMakeLists.txt#L226-L230 in combination with our dependency on zlib-ng? The variable MINIZIP_DEP_PKG is later (lines 736..741) used to populate the list of dependencies for minizip-config.cmake. The logic emits ZLIBNG if zlib-ng is found or if not in compat mode, else ZLIB is emitted. If I build with USE=compat and remove zlib-ng prior to configuring the package, I verified that it emits find_dependency(ZLIB REQUIRED) instead of find_dependency(ZLIBNG REQUIRED). Even without USE=compat but zlib-ng not installed, it emits ZLIB, although I'm not sure yet why that's the case. So far, I'd say we should possibly drop the zlib-ng dep for now and only add it in as an any-of-depencency with zlib once it's ready to be replaced completely. As for the OCIO dep which brought me to this issue, they require zlib and minizip-ng (configured with MZ_ZLIB=ON and MZ_COMPAT=OFF), but not zlib-ng and it seems to work on their github CI workflows. An issue for adding cmake config files is at https://github.com/zlib-ng/zlib-ng/issues/1320 |