Bug 894994

Summary:	net-libs/libssh2: compilation warning: no return statement in function returning non-void
Product:	Gentoo Linux	Reporter:	Jocelyn Mayer <l_indien>
Component:	Current packages	Assignee:	Gentoo Netmon project <netmon>
Status:	UNCONFIRMED ---
Severity:	minor	CC:	l_indien, mgorny
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/libssh2/libssh2/commit/f0417cb1967331c8dcb38a96ab889ecdf71f6dcb
See Also:	https://github.com/libssh2/libssh2/issues/798
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch proposal to fix the missing return value.

Description Jocelyn Mayer 2023-02-16 21:40:10 UTC

When compiling libssh2, a warning is emitted:
libssh2-1.10.0/tests/openssh_fixture.c:218:1:
warning: no return statement in function returning non-void [-Wreturn-type]

This should not be critical as it is only in tests subdirectory.
A ticket has opened upstream with a fix proposal

Reproducible: Always

Steps to Reproduce:
1. Build net-libs/libssh2
2. Check the build logs
3.
Actual Results:  
The described warning is emitted

Expected Results:  
No such a warning should be seen

Comment 1 Jocelyn Mayer 2023-02-16 21:42:26 UTC

Created attachment 851910 [details, diff]
Patch proposal to fix the missing return value.

Note: as I don't know about win32 API, I cannot be sure the fix would be correct in this case; it would for POSIX case.