| Summary: | dev-libs/cyrus-sasl: minor compilation issue of srp plugin (plugins/srp_init.c:41:1: warning: type of 'srp_client_plug_init' does not match original declaration [-Wlto-type-mismatch]) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jocelyn Mayer <l_indien> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | l_indien, sam |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/cyrusimap/cyrus-sasl/issues/757 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 618550 | ||
| Attachments: | cyrus-sasl srp plugin patch to avoid the described warnings | ||
|
Description
Jocelyn Mayer
2023-02-16 06:49:19 UTC
Good spot. Thanks for filing these, code quality is important. FWIW: for the upstream reports, most projects will prefer a PR rather than an inline patch in a bug, but if you're giving a patch in a bug upstream (no need if attaching), make sure to use Markdown so it renders ok, like this: ``` --- a/foo.c +++ b/foo.c ... ``` (it's just 3 backticks above/below the 'code' bit) It's possible that the unused int is there for ABI reasons (so they can add something later without breaking ABI), but it's a bit weird. So they might prefer to do something else to fix the warning. (In reply to Sam James from comment #1) > Good spot. Thanks for filing these, code quality is important. > > FWIW: for the upstream reports, most projects will prefer a PR rather than > an inline patch in a bug, but if you're giving a patch in a bug upstream (no > need if attaching), make sure to use Markdown so it renders ok, like this: > ``` > --- a/foo.c > +++ b/foo.c > ... > ``` > > (it's just 3 backticks above/below the 'code' bit) oh, OK, I did not check the view in the upstream ticket... Just updated the inline patch upstream... (In reply to Sam James from comment #2) > It's possible that the unused int is there for ABI reasons (so they can add > something later without breaking ABI), but it's a bit weird. So they might > prefer to do something else to fix the warning. it does not seem to me that this is the case as the macro used to define the headers declaration for plugins init routine does not declare this argument. Then, using it from a caller would lead to some kind of issues, I guess. And, as it seems, other plugins using this macro do not implement this extra argument... Upstream will decide the best way to fix it... The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9f10d53dc71950701eb206c84c62019ac0fe44ca commit 9f10d53dc71950701eb206c84c62019ac0fe44ca Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-04-26 05:18:38 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-04-26 12:48:54 +0000 dev-libs/cyrus-sasl: mark as LTO-unsafe Fixed upstream in git master. Closes: https://bugs.gentoo.org/894684 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-libs/cyrus-sasl/cyrus-sasl-2.1.28-r4.ebuild | 7 +++++++ 1 file changed, 7 insertions(+) |
