Bug 894642

Summary:	app-text/crf++-0.58-r1 fails to compile (MUSL-CLANG-SYSTEM): darts.h:407:5: error: ISO C++17 does not allow register storage class specifier [-Wregister]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	CJK Team <cjk>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/31053
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-02-15 18:57:23 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-text/crf++-0.58-r1 fails to compile (MUSL-CLANG-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-CLANG-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc + clang16 but this bug MAY or MAY NOT BE related to musl/clang16.

Comment 1 Agostino Sarubbo gentoo-dev

2023-02-15 18:57:26 UTC

Created attachment 851478 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2024-05-09 01:13:42 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4c9c92f3f5803e331eed97d068ad644789513c4e

commit 4c9c92f3f5803e331eed97d068ad644789513c4e
Author:     Brahmajit Das <brahmajit.xyz@gmail.com>
AuthorDate: 2023-05-16 07:05:42 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-09 01:12:05 +0000

    app-text/crf++: Removing register keywords
    
    The register keyword has been dropped since C++17.
    
    Closes: https://bugs.gentoo.org/894642
    Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/31053
    Signed-off-by: Sam James <sam@gentoo.org>

 app-text/crf++/crf++-0.58-r2.ebuild             | 47 ++++++++++++++++++++
 app-text/crf++/files/crf++-0.58-registers.patch | 57 +++++++++++++++++++++++++
 2 files changed, 104 insertions(+)