Bug 894494 – dev-db/mydumper-0.14.5.2 does not respect CFLAGS

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2023-02-15 06:51:34 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-db/mydumper-0.13.1.2 does not respect CFLAGS.
Discovered on: amd64 (internal ref: ci)

NOTE:
To reproduce this issue you may want to add "-frecord-gcc-switches" to CFLAGS/CXXFLAGS/FFLAGS/FCFLAGS. If this is not something about c/c++ context see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect CFLAGS.

[Comment 1 Agostino Sarubbo 2023-02-15 06:51:36 UTC]

Created attachment 851168 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2023-04-26 06:42:20 UTC]

ci has reproduced this issue with version 0.14.4.1 - Updating summary.

[Comment 3 Agostino Sarubbo 2023-07-14 11:44:39 UTC]

ci has reproduced this issue with version 0.14.5.2 - Updating summary.

[Comment 4 Larry the Git Cow 2024-03-11 14:24:03 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=18e0de0e6777e2210f505e3cc6640326cba799e1

commit 18e0de0e6777e2210f505e3cc6640326cba799e1
Author:     Eli Schwartz <[e-mail]>
AuthorDate: 2024-03-11 01:25:07 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-11 14:22:47 +0000

    dev-db/mydumper: use a real patch to fix ignored CFLAGS
    
    Using seds just ended up nastily failing to do anything:
    
     * SED: the following did not cause any changes
     *     sed -i -e 's|-O3 -g -Werror|${CMAKE_C_FLAGS}|' CMakeLists.txt || die;
     * no-op: -e s|-O3 -g -Werror|${CMAKE_C_FLAGS}|
    
    But patch files are reliable since they will die if they don't apply
    anymore.
    
    Closes: https://bugs.gentoo.org/894494
    Signed-off-by: Eli Schwartz <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 ...per-0.14-Do-not-overwrite-the-user-CFLAGS.patch | 29 ++++++++++++++++++++++
 ...per-0.15-Do-not-overwrite-the-user-CFLAGS.patch | 25 +++++++++++++++++++
 dev-db/mydumper/mydumper-0.14.5.2.ebuild           |  7 +++---
 dev-db/mydumper/mydumper-0.15.2.8.ebuild           |  5 ++--
 4 files changed, 59 insertions(+), 7 deletions(-)