Summary: | dev-tcltk/tclx-8.4.4-r1 fails to compile (MUSL-CLANG-SYSTEM): tclXunixSock.c:198:13: error: call to undeclared function rresvport; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | TCL/TK Project <tcltk> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | sam |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 870412 | ||
Attachments: | build.log |
Description
Agostino Sarubbo
2023-02-13 13:41:01 UTC
Created attachment 850686 [details]
build.log
build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: ./generic/tclXprofile.c:323:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] ./unix/tclXunixCmds.c:109:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] ./unix/tclXunixSock.c:198:13: error: call to undeclared function 'rresvport'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=281535f88931fec48c2dd2fa3a8f4f3cfac201b0 commit 281535f88931fec48c2dd2fa3a8f4f3cfac201b0 Author: Alfredo Tupone <tupone@gentoo.org> AuthorDate: 2023-03-15 21:11:27 +0000 Commit: Alfredo Tupone <tupone@gentoo.org> CommitDate: 2023-03-15 21:12:24 +0000 dev-tcltk/tclx: filter rresvport if not present Closes: https://bugs.gentoo.org/894176 Signed-off-by: Alfredo Tupone <tupone@gentoo.org> dev-tcltk/tclx/files/tclx-8.4.4-musl.patch | 25 ++++++++++++++++++++++ .../{tclx-8.4.4-r3.ebuild => tclx-8.4.4-r4.ebuild} | 1 + 2 files changed, 26 insertions(+) rresvport may need _BSD_SOURCE to be available. I'll check later if I remember. (Your fix is reasonable, I'm just wondering if musl really doesn't have it) (In reply to Sam James from comment #5) > (Your fix is reasonable, I'm just wondering if musl really doesn't have it) doesn't seem like it tested: >#define _BSD_SOURCE >#include <netdb.h> > >int main() { > int port; > rresvport(&port); > return 0; >} and it did not work also: grep -rsin "rresvport" in musl.git did not return anything. also^2: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9c93e299c4c4db9edf7c120a87a6f132cbbdfef8 (In reply to Alfred Persson from comment #6) > (In reply to Sam James from comment #5) > > (Your fix is reasonable, I'm just wondering if musl really doesn't have it) > > doesn't seem like it > > tested: > >#define _BSD_SOURCE > >#include <netdb.h> > > > >int main() { > > int port; > > rresvport(&port); > > return 0; > >} > > and it did not work > > also: grep -rsin "rresvport" in musl.git did not return anything. > > also^2: > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > ?id=9c93e299c4c4db9edf7c120a87a6f132cbbdfef8 should probably implement this same patch for those packages too instead of just package.mask:ing. Can't right now though nice, thanks! |