Summary: | dev-libs/rocm-opencl-runtime-5.3.3-r1: Fails to compile: rocvirtual.hpp:27:10: fatal error: hsa.h: No such file or directory | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Elizabeth Doughty <thymelizabeth> |
Component: | Current packages | Assignee: | Craig Andrews <candrews> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ansla80, chaneybenjamini, creideiki+gentoo-bugzilla, gentoo, ka.nick, mike, paolo.pedroni, peter, xgreenlandforwyy |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://github.com/gentoo/gentoo/pull/29513 https://github.com/gentoo/gentoo/pull/29675 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Build log for rocm-opencl-runtime
Quick fix |
Description
Elizabeth Doughty
2023-02-08 11:18:29 UTC
Created attachment 850156 [details]
Build log for rocm-opencl-runtime
I get the same failure. /usr/include/hsa needs to be added somewhere I wrote a patch to manually add the hsa/ directory where needed Created attachment 850188 [details, diff]
Quick fix
I have the same issue. (In reply to Mike Lothian from comment #4) > Created attachment 850188 [details, diff] [details, diff] > Quick fix How is this to be applied? I tried dropping it into /etc/portage/patches/dev-libs/rocm-opencl-runtime/ but I got patch errors. The first was: =============== can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |diff --git a/device/rocm/roccounters.hpp b/device/rocm/roccounters.hpp |index ffc9fad..45ebbe6 100644 |--- a/device/rocm/roccounters.hpp |+++ b/device/rocm/roccounters.hpp -------------------------- =============== Several more like that. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=61a151872957434dc76802939e52cf325f23bc31 commit 61a151872957434dc76802939e52cf325f23bc31 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-02-09 20:20:30 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-02-09 20:20:35 +0000 dev-libs/rocm-opencl-runtime: restore 5.3.3 Fished out of 154ece10a9374160e04dc82f3dd3a46548cd1c0f. Bug: https://bugs.gentoo.org/893602 Signed-off-by: Sam James <sam@gentoo.org> .../rocm-opencl-runtime-5.3.3.ebuild | 122 +++++++++++++++++++++ 1 file changed, 122 insertions(+) (In reply to Larry the Git Cow from comment #7) > The bug has been referenced in the following commit(s): > > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > ?id=61a151872957434dc76802939e52cf325f23bc31 > > commit 61a151872957434dc76802939e52cf325f23bc31 > Author: Sam James <sam@gentoo.org> > AuthorDate: 2023-02-09 20:20:30 +0000 > Commit: Sam James <sam@gentoo.org> > CommitDate: 2023-02-09 20:20:35 +0000 > > dev-libs/rocm-opencl-runtime: restore 5.3.3 > > Fished out of 154ece10a9374160e04dc82f3dd3a46548cd1c0f. > > Bug: https://bugs.gentoo.org/893602 > Signed-off-by: Sam James <sam@gentoo.org> > > .../rocm-opencl-runtime-5.3.3.ebuild | 122 > +++++++++++++++++++++ > 1 file changed, 122 insertions(+) This does not help. The bug is introduced by bbff88f734f62381b0a0624b4b2d182a8d4b8589 (dev-libs/rocr-runtime: disable non-FHS install), but apparently rocclr is not prepared for standard install location. I'll back-port a patch from upstream to fix this. (In reply to Yiyang Wu from comment #8) > This does not help. The bug is introduced by > bbff88f734f62381b0a0624b4b2d182a8d4b8589 (dev-libs/rocr-runtime: disable > non-FHS install), but apparently rocclr is not prepared for standard install > location. I'll back-port a patch from upstream to fix this. Ah, thanks. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=794758cd9e9393bccfddf89d160810220a5913df commit 794758cd9e9393bccfddf89d160810220a5913df Author: Yiyang Wu <xgreenlandforwyy@gmail.com> AuthorDate: 2023-02-10 03:53:33 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-02-10 04:25:42 +0000 dev-libs/rocm-opencl-runtime: fix rocclr compile issue Due to bbff88f734f62381b0a0624b4b2d182a8d4b8589, /usr/include/hsa.h is gone, so backport patch for rocclr to fix compile error. Also remove the unused prefix.eclass inherit Closes: https://bugs.gentoo.org/893602 Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> .../files/rocclr-5.3.3-fix-include.patch | 218 +++++++++++++++++++++ .../rocm-opencl-runtime-5.3.3-r1.ebuild | 3 +- .../rocm-opencl-runtime-5.3.3.ebuild | 122 ------------ 3 files changed, 220 insertions(+), 123 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f98177a3fe2ea8cf1818daec64268f9377176902 commit f98177a3fe2ea8cf1818daec64268f9377176902 Author: Yiyang Wu <xgreenlandforwyy@gmail.com> AuthorDate: 2023-02-10 04:00:28 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-02-10 04:25:42 +0000 dev-util/hip: fix rocclr compile issue Due to bbff88f734f62381b0a0624b4b2d182a8d4b8589, /usr/include/hsa.h is gone, so backport patch for rocclr to fix compile error. Bug: https://bugs.gentoo.org/893602 Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/29513 Signed-off-by: Sam James <sam@gentoo.org> dev-util/hip/files/rocclr-5.3.3-fix-include.patch | 218 ++++++++++++++++++++++ dev-util/hip/hip-5.3.3-r3.ebuild | 4 + 2 files changed, 222 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=374c8828b3a2bca0b55ebcce9b5b8b5c710647a1 commit 374c8828b3a2bca0b55ebcce9b5b8b5c710647a1 Author: Yiyang Wu <xgreenlandforwyy@gmail.com> AuthorDate: 2023-02-20 02:15:58 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-02-20 04:26:02 +0000 dev-libs/rocm-opencl-runtime: Fix gcc-13 build Backport two patches for missing includes Also apply patch for file rocm reorg (hsa/hsa.h) to 5.1.3 ebuild, which fix compilation issue Closes: https://bugs.gentoo.org/895382 Bug: https://bugs.gentoo.org/893602 Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/29675 Signed-off-by: Sam James <sam@gentoo.org> .../files/rocclr-5.3.3-gcc13.patch | 25 ++++++++++++++++++++++ .../files/rocm-opencl-runtime-5.3.3-gcc13.patch | 25 ++++++++++++++++++++++ .../rocm-opencl-runtime-5.1.3.ebuild | 5 ++++- .../rocm-opencl-runtime-5.3.3-r1.ebuild | 3 +++ 4 files changed, 57 insertions(+), 1 deletion(-) |