Bug 892834

Summary:	sys-apps/kbd-2.6.0 redefines _FORTIFY_SOURCE (HARDENED-SYSTEM)
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	normal	CC:	egor-gl
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/legionus/kbd/pull/103
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	847148
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-02-01 14:58:41 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-apps/kbd-2.5.1 overwrites CFLAGS/CXXFLAGS or adds uncommon ones (HARDENED-SYSTEM).
Discovered on: amd64 (internal ref: hardened_tinderbox)

NOTE:
(HARDENED-SYSTEM) in the summary means that the bug was found on a machine that runs an hardened profile with -D_FORTIFY_SOURCE=3 and -D_GLIBCXX_ASSERTIONS (https://www.gentoo.org/support/news-items/2023-01-01-hardening-fortify-assertions.html) but this bug MAY or MAY NOT BE related to the changes related to hardened.
This QA check is tinderbox-only, there is the list of the flags that should be dropped out, if you think it is a false positive please let me know..

Comment 1 Agostino Sarubbo gentoo-dev

2023-02-01 14:58:43 UTC

Created attachment 849630 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2023-06-13 08:19:47 UTC

tinderbox_musl has reproduced this issue with version 2.6.0 - Updating summary.

Comment 3 Larry the Git Cow gentoo-dev

2023-10-04 15:28:55 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a82615f6b9ef054b0d937bbde647c552905945e6

commit a82615f6b9ef054b0d937bbde647c552905945e6
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-10-04 14:04:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-10-04 15:10:43 +0000

    sys-apps/kbd: don't redefine _FORTIFY_SOURCE
    
    Closes: https://bugs.gentoo.org/892834
    Signed-off-by: Sam James <sam@gentoo.org>

 .../kbd-2.6.3-no-redefine-fortify-source.patch     | 171 +++++++++++++++++++++
 sys-apps/kbd/kbd-2.6.3-r1.ebuild                   |  94 +++++++++++
 2 files changed, 265 insertions(+)