Bug 891679

Summary:	dev-cpp/doctest-2.4.10 adds -Werror flag on its own (LIBARCHIVE-SYSTEM)
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Petr Vaněk <arkamar>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, proxy-maint
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-01-22 09:34:45 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-cpp/doctest-2.4.9 adds -Werror flag on its own (LIBARCHIVE-SYSTEM).
Discovered on: amd64 (internal ref: libarchive_tinderbox)

NOTE:
(LIBARCHIVE-SYSTEM) in the summary means that the bug was found on a machine that runs app-alternatives/tar and app-alternatives/cpio with [-gnu,+libarchive] but this bug MAY or MAY NOT BE related to the tar/cpio implementation.
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

Comment 1 Agostino Sarubbo gentoo-dev

2023-01-22 09:34:48 UTC

Created attachment 848973 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2023-03-04 08:54:14 UTC

ci has reproduced this issue with version 2.4.10 - Updating summary.

Comment 3 Larry the Git Cow gentoo-dev

2023-03-05 11:19:40 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=82c15976e4ada7e9320b666b9d2252a11e10e7fa

commit 82c15976e4ada7e9320b666b9d2252a11e10e7fa
Author:     Petr Vaněk <arkamar@atlas.cz>
AuthorDate: 2023-03-05 08:34:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-05 11:19:20 +0000

    dev-cpp/doctest: remove automatic -Werror
    
    doctest builds tests with -Werror flag enabled by default. This is not
    wanted, let's remove it.
    
    Closes: https://bugs.gentoo.org/891679
    Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
    Closes: https://github.com/gentoo/gentoo/pull/29929
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-cpp/doctest/doctest-2.4.10.ebuild | 5 +++++
 1 file changed, 5 insertions(+)