Bug 89134 – User name in xjack hack from xscreensaver

• Product: Gentoo Linux
• Status: RESOLVED WONTFIX

[Description Krzysztof Pawlik (RETIRED) 2005-04-14 15:33:07 UTC]

xjack displays this text:

"All work and no play makes Jack a dull boy.  "

It's possible that "Jack" would be replaced with name of user for which xscreensaver is running. Attached patch does it.

It could be toggled via USE flag (for example "xjackuser").

Could it be included in portage?

[Comment 1 Krzysztof Pawlik (RETIRED) 2005-04-14 15:33:36 UTC]

Created attachment 56302 [details, diff]
xjack-username.diff

Patch for xjack.c

[Comment 2 Krzysztof Pawlik (RETIRED) 2005-05-03 04:21:22 UTC]

Created attachment 57910 [details, diff]
xscreensaver-4.20.ebuild.patch

Patch for ebuild.

[Comment 3 Krzysztof Pawlik (RETIRED) 2005-05-03 04:23:12 UTC]

Created attachment 57911 [details]
xscreensaver-4.20-xjack-boy-girl.patch.bz2

Patch that adds two new hacks: xjack-boy and xjack-girl. xjack-boy displays
"...${USER} a dull boy." and xjack-girl displays "...${USER} a dull girl.".
Original xjack is also available.

[Comment 4 Krzysztof Pawlik (RETIRED) 2005-05-03 06:20:18 UTC]

Created attachment 57920 [details]
xscreensaver-4.20.ebuild.patch

Patch against xscreensaver-4.20.ebuild (from portage) - it has the patch in
SRC_URI, not in files/

[Comment 5 Krzysztof Pawlik (RETIRED) 2005-05-04 13:48:29 UTC]

Upstream refused to include this patch:

> Krzysiek Pawlik wrote:
>> Hi.
>> 
>> There's a bug reported about XScreenSaver at
>> https://bugs.gentoo.org/show_bug.cgi?id=89134 . It adds two new hacks:
>> xjack-girl and xjack-boy. Could it be possible to get it included with
>> next release of XScreenSaver?
> 
> Absolutely not, that's completely stupid.
> 
> It's a *quote*.  Customizing it is dumb.

[Comment 6 Krzysztof Pawlik (RETIRED) 2005-05-25 14:39:02 UTC]

Quote from IRC:
<pYrania> we try to include every pkg as is, only patches that are really
required are made
<nelchael> ok