| Summary: | games-emulation/jgemu - keywording request, x86, arm, arm64, ppc, ppc64 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | orbea <orbea> | ||||
| Component: | Keywording | Assignee: | orbea <orbea> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | normal | CC: | jstein, matoro_gentoo, proxy-maint | ||||
| Priority: | Normal | Keywords: | PullRequest | ||||
| Version: | unspecified | Flags: | nattka:
sanity-check+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| See Also: |
https://github.com/gentoo/gentoo/pull/34205 https://github.com/gentoo/gentoo/pull/35976 |
||||||
| Whiteboard: | |||||||
| Package list: |
dev-libs/miniz
dev-libs/trio
media-libs/jg
games-emulation/jgrf
games-emulation/bsnes-jg
games-emulation/cega-jg
games-emulation/gambatte-jg
games-emulation/geolith-jg
games-emulation/jollycv-jg
games-emulation/mednafen-jg
games-emulation/melonds-jg
games-emulation/mgba-jg
games-emulation/nestopia-jg
games-emulation/prosystem-jg
dev-util/rgbds
games-emulation/sameboy-jg
games-emulation/vecx-jg
|
Runtime testing required: | Yes | ||||
| Bug Depends on: | 867001, 914196 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
orbea
2023-01-17 16:05:55 UTC
Sanity check failed:
> games-emulation/geolith-jg-0.1.0
> depend ~arm stable profile default/linux/arm/17.0 (15 total)
> dev-libs/miniz
> depend ~arm dev profile default/linux/arm/17.0/armv4 (42 total)
> dev-libs/miniz
> rdepend ~arm stable profile default/linux/arm/17.0 (15 total)
> dev-libs/miniz
> rdepend ~arm dev profile default/linux/arm/17.0/armv4 (42 total)
> dev-libs/miniz
> games-emulation/mednafen-jg-1.31.0
> depend ~arm stable profile default/linux/arm/17.0 (41 total)
> >=dev-libs/trio-1.17
> depend ~arm dev profile default/linux/arm/17.0/armv4 (45 total)
> >=dev-libs/trio-1.17
> rdepend ~arm stable profile default/linux/arm/17.0 (41 total)
> >=dev-libs/trio-1.17
> rdepend ~arm dev profile default/linux/arm/17.0/armv4 (45 total)
> >=dev-libs/trio-1.17
> games-emulation/jgrf-1.0.2-r1
> depend ~arm stable profile default/linux/arm/17.0 (15 total)
> dev-libs/miniz
> depend ~arm dev profile default/linux/arm/17.0/armv4 (42 total)
> dev-libs/miniz
> rdepend ~arm stable profile default/linux/arm/17.0 (15 total)
> dev-libs/miniz
> rdepend ~arm dev profile default/linux/arm/17.0/armv4 (42 total)
> dev-libs/miniz
All sanity-check issues have been resolved It all builds on ~arm64, even with USE=doc. I don't have the controller for any run time testing. > THanks for testing! > I don't have the controller for any run time testing. You can assign the keyboard as a controller, the man page in the jgrf package should be rather comprehensive. arm64 done x86 done ppc done ppc64 done On arm:
In file included from /var/tmp/portage/games-emulation/bsnes-jg-1.1.2/work/bsnes-1.1.2/src/processor/wdc65816.hpp:27,
from /var/tmp/portage/games-emulation/bsnes-jg-1.1.2/work/bsnes-1.1.2/src/cpu.hpp:26,
from /var/tmp/portage/games-emulation/bsnes-jg-1.1.2/work/bsnes-1.1.2/src/controller.cpp:22:
/var/tmp/portage/games-emulation/bsnes-jg-1.1.2/work/bsnes-1.1.2/src/processor/endian.hpp:27:4: error: #error "Endianness is unknown, update endian.h"
27 | #error "Endianness is unknown, update endian.h"
| ^~~~~
This appears to be because they are defining off __LITTLE_ENDIAN__. There is a complaint from gcc that this is not consistent here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60490
Would you mind telling me what arm device is this? Can I assume you are using little endian? (In reply to orbea from comment #10) > Would you mind telling me what arm device is this? Can I assume you are > using little endian? This is using a clean armv7a stage3 chroot on an arm64 device. Yes, it's LE, but it doesn't define __LITTLE_ENDIAN__ for some reason. It does define __BYTE_ORDER__ = __ORDER_LITTLE_ENDIAN__ Created attachment 878398 [details]
preproc.txt
This is the complete output of the following command:
gcc -dM -E - < /dev/null | sort
Thanks for that info, I also found this useful reference. https://sourceforge.net/p/predef/wiki/Endianness/ With that I updated the endian.hpp file in bsnes-jg usptream and backported the patch to Gentoo in a PR. https://github.com/gentoo/gentoo/pull/34205 I'm sure it will fix your issue and perhaps some others too. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=65681f9674bb4393c8047f98fe43744632e97ac6 commit 65681f9674bb4393c8047f98fe43744632e97ac6 Author: orbea <orbea@riseup.net> AuthorDate: 2023-12-10 00:44:57 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-05 05:24:05 +0000 games-emulation/bsnes-jg: fix arm endianness detection Reported in comment #9 in issue #891201. Bug: https://bugs.gentoo.org/891201 Upstream-PR: https://gitlab.com/jgemu/bsnes/-/merge_requests/371 Upstream-Commit: https://gitlab.com/jgemu/bsnes/-/commit/647e868f3d97bd937c46ecf312bbfbc25b816dc1 Signed-off-by: orbea <orbea@riseup.net> Closes: https://github.com/gentoo/gentoo/pull/34205 Signed-off-by: Sam James <sam@gentoo.org> games-emulation/bsnes-jg/bsnes-jg-1.1.2-r1.ebuild | 50 +++++++++++++++++++ .../bsnes-jg/files/bsnes-jg-1.1.2-endianness.patch | 58 ++++++++++++++++++++++ 2 files changed, 108 insertions(+) @matoro, the fix was merged in Gentoo now, would you mind trying again? :) arm done all arches done Thank you very much, its greatly appreciated! The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3cdf7dff8db89871e20ce105d4c23feb18b66f6a commit 3cdf7dff8db89871e20ce105d4c23feb18b66f6a Author: orbea <orbea@riseup.net> AuthorDate: 2024-03-30 19:16:22 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2024-04-29 08:45:19 +0000 games-emulation/jgemu: keyword 1.0.0 for ~arm, ~arm64, ~ppc, ~ppc64, ~x86 Already done for all related packages. Bug: https://bugs.gentoo.org/891201 Signed-off-by: orbea <orbea@riseup.net> Signed-off-by: Joonas Niilola <juippis@gentoo.org> games-emulation/jgemu/jgemu-1.0.0.ebuild | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) |
