Bug 890276

Summary:	net-im/pidgin warning: FORTIFY_SOURCE redefined with gcc12 hardened _F_S=3
Product:	Gentoo Linux	Reporter:	genBTC
Component:	Current packages	Assignee:	Gentoo Linux bug wranglers <bug-wranglers>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	847148
Attachments:	pidgin build.log

Description genBTC 2023-01-09 08:41:27 UTC

When using gentoo-hardened with the new  fortify-source-3.patch  built into Gcc-12.2.1_p20221231 ,
pidgin package results in a warning about a definition redefined collision.

<command-line>: warning: "_FORTIFY_SOURCE" redefined
<built-in>: note: this is the location of the previous definition

Meaning the package has _F_S=2 hardcoded internally somewhere and that flag should be stripped so _F_S=3 can take effect without conflict.

I think this one uses autoconf to do set up the FORTIFY but ac_arg_enable fortify, not the ax_add_fortify_source, so it could be maybe switched

Reproducible: Always

Comment 1 genBTC 2023-01-09 08:41:55 UTC

Created attachment 848006 [details]
pidgin build.log

warning: "_FORTIFY_SOURCE" redefined

Comment 2 Larry the Git Cow gentoo-dev

2023-01-09 09:52:12 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=23401db9735b9ef27261f5f098d79d86648b13c2

commit 23401db9735b9ef27261f5f098d79d86648b13c2
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-01-09 09:50:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-09 09:52:05 +0000

    net-im/pidgin: don't downgrade FORTIFY_SOURCE
    
    Closes: https://bugs.gentoo.org/890276
    Signed-off-by: Sam James <sam@gentoo.org>

 net-im/pidgin/{pidgin-2.14.10.ebuild => pidgin-2.14.10-r1.ebuild} | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)