Bug 890271

Summary:	sys-apps/sysvinit + hardened gcc + _FORTIFY_SOURCE redefined
Product:	Gentoo Linux	Reporter:	genBTC
Component:	Current packages	Assignee:	William Hubbs <williamh>
Status:	RESOLVED FIXED
Severity:	normal	CC:	base-system
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	847148
Attachments:	build.log

Description genBTC 2023-01-09 07:24:16 UTC

When using gentoo-hardened with the new F_S=3 patch built into Gcc-12.2.1_p20221231 ,
sysvinit package results in a warning about a definition redefined collision.

<command-line>: warning: "_FORTIFY_SOURCE" redefined
<built-in>: note: this is the location of the previous definition

package has _F_S=2 hardcoded into src/Makefile (top line), and likely needs an ebuild tweak similar to the one that already exists on line 58 in the .ebuild that had been tweaked to sed a conflicting stack-protector flag out.

Reproducible: Always

Comment 1 genBTC 2023-01-09 07:24:49 UTC

Created attachment 848003 [details]
build.log

version 3.06
version 3.05 also affected

Comment 2 Larry the Git Cow gentoo-dev

2023-01-09 07:32:02 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=393a30cb0ee700a2fe25b463c1049ededed0f71c

commit 393a30cb0ee700a2fe25b463c1049ededed0f71c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-01-09 07:31:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-09 07:31:37 +0000

    sys-apps/sysvinit: stop downgrading FORTIFY_SOURCE
    
    Closes: https://bugs.gentoo.org/890271
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/sysvinit/{sysvinit-3.06.ebuild => sysvinit-3.06-r1.ebuild} | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)