Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 889910

Summary: dev-libs/libphonenumber-8.12.39 adds -Werror flag on its own
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Gentoo KDE team <kde>
Status: RESOLVED FIXED    
Severity: normal CC: esigra
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 260867    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2023-01-06 06:50:06 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/libphonenumber-8.12.39 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: usr-merge_tinderbox)

NOTE:
(USR-MERGE-SYSTEM) in the summary means that the bug was found on a machine that runs default/linux/amd64/17.1/systemd/merged-usr profile but this bug MAY or MAY NOT BE related to the new profile.
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2023-01-06 06:50:08 UTC
Created attachment 847604 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2024-10-05 11:12:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8562873238086a94ba2a9b9ecad1059fd1cd689c

commit 8562873238086a94ba2a9b9ecad1059fd1cd689c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-10-05 11:06:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-10-05 11:10:11 +0000

    dev-libs/libphonenumber: add 8.13.47
    
    * Replace CMake patch with newer version from Exherbo (original came
      from there too)
    * Import another patch from Exherbo for newer abseil-cpp (fixes linking
      w/ lld, mold)
    * Drop -Werror
    * Wire up tests again (sorry, not rebasing the CMake patch, this is
      good enough ;))
    
    Closes: https://bugs.gentoo.org/889910
    Closes: https://bugs.gentoo.org/923946
    Closes: https://bugs.gentoo.org/939873
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/libphonenumber/Manifest                   |  1 +
 .../files/libphonenumber-8.13.47-cmake.patch       | 31 +++++++++++
 ...bphonenumber-8.13.47-protobuf-link-abseil.patch | 24 +++++++++
 .../files/libphonenumber-8.13.47-werror.patch      | 23 +++++++++
 .../libphonenumber/libphonenumber-8.13.47.ebuild   | 60 ++++++++++++++++++++++
 5 files changed, 139 insertions(+)