Bug 889178 – media-video/mpv-0.35.0-r1 massive cpu increase with v0.35 (cause: DR on Intel iGPU)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description David Duchesne 2022-12-31 11:13:58 UTC]

Hi,
Since 0.35.0-r1 update, any video drop frames.

[   0.629][d][vd] Allocating new DR image...
[   0.666][d][vd] Allocating new DR image...
[   0.788][d][vd] Allocating new DR image...
[   1.194][d][vd] Allocating new DR image...

See this : https://github.com/mpv-player/mpv/issues/10972#issuecomment-1340100762
It would be helpful to add a quick note in the ebuild to warn the user of such old hardware to either set :
vd-lavc-dr=no 

or :

vo=gpu-next (if libplacebo USE flag is enabled, which is default)

in .config/mpv/mpv.conf

This is not needed with previous version of mpv (0.34), it only started to happen with 0.35.

Reproducible: Always

[Comment 1 Ionen Wolkens 2023-01-06 21:27:32 UTC]

Unfortunate when it does, but giving me the impression this is affecting a rather minimal amount of people under specific use case (old hardware + probably not wayland + need an affected -vo output, etc..).

Giving a message would just be unnecessary noise to most, and trying to probe what's in use to narrow it down sounds messy. Also probably wouldn't be seen much at this point given it's already stable and installed anyway.

If you really want to communicate this somewhere, you may want to edit the wiki[1] (it has a troubleshooting section).

[1] https://wiki.gentoo.org/wiki/Mpv

[Comment 2 Ionen Wolkens 2023-01-06 22:08:56 UTC]

On a side-note, upstream did pin the issue for visibility now, hopefully it'll help affected people.

I'll keep an eye on it, if there's a non-invasive fix could consider backporting.

[Comment 3 Ionen Wolkens 2023-01-08 21:37:00 UTC]

(In reply to Ionen Wolkens from comment #2)
> On a side-note, upstream did pin the issue for visibility now, hopefully
> it'll help affected people.
> 
> I'll keep an eye on it, if there's a non-invasive fix could consider
> backporting.

Upstream seem to be planning mpv-0.35.1 soon'ish and I'd assume it'll include the PR[1] to do vd-lavc-dr=auto that will hopefully solve this. So I'll just wait for .1 and see.

I'll leave this open until then just for visibility (the WONTFIX was mostly about not adding a message).

[1] https://github.com/mpv-player/mpv/pull/10999

[Comment 4 David Duchesne 2023-01-09 14:02:39 UTC]

Alright, thanks Ionen. Wait and see then.
Otherwise, you're right. This would best fit in the wiki (Archlinux added a note in their wiki), I only need to create an account to do that. :)
Cheers

[Comment 5 Larry the Git Cow 2023-01-28 18:27:31 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ad85aede566131748cdc6fbfc7e2a97930b26f56

commit ad85aede566131748cdc6fbfc7e2a97930b26f56
Author:     Ionen Wolkens <[e-mail]>
AuthorDate: 2023-01-28 17:29:09 +0000
Commit:     Ionen Wolkens <[e-mail]>
CommitDate: 2023-01-28 18:27:20 +0000

    media-video/mpv: add 0.35.1
    
    bugfix-only release with cherry picks from master, so likely
    won't wait very long to stable it
    
    wrt bug #889178, upstream has added an automated mode used
    by default so it doesn't enable DR when it's not benefical
    
    meson_src_test addition didn't make in this version,
    so keeping tests unchanged from 0.35.0
    
    Closes: https://bugs.gentoo.org/889178
    Signed-off-by: Ionen Wolkens <[e-mail]>

 media-video/mpv/Manifest          |   1 +
 media-video/mpv/mpv-0.35.1.ebuild | 297 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 298 insertions(+)