Bug 889078

Summary:	app-text/crengine-ng-0.9.3 fails to compile (CLANG-STRICTER-SYSTEM): fonts.c:945:7: error: call to undeclared function strcasecmp; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Andrey Grozin <grozin>
Status:	RESOLVED FIXED
Severity:	normal	CC:	valexlin
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412
Attachments:	build.log 0001-Compile-warnings-errors-fixed-strcasecmp-missing-pro.patch

Description Agostino Sarubbo gentoo-dev

2022-12-31 10:05:05 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-text/crengine-ng-0.9.3 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

Comment 1 Agostino Sarubbo gentoo-dev

2022-12-31 10:05:08 UTC

Created attachment 846112 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2022-12-31 10:05:09 UTC

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: thirdparty/antiword/CMakeFiles/cre_antiword.dir/fonts.c.o 
FAILED: thirdparty/chmlib/CMakeFiles/cre_chmlib.dir/src/chm_lib.c.o 
/var/tmp/portage/app-text/crengine-ng-0.9.3/work/crengine-ng-0.9.3/thirdparty/antiword/fonts.c:945:7: error: call to undeclared function 'strcasecmp'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]

Comment 3 Aleksey Chernov 2023-01-01 06:24:15 UTC

Fixed in upstream https://gitlab.com/coolreader-ng/crengine-ng/-/commit/62106833d4e8af5325ed7a55c7a897e43a52bb20
Will be in the next version.

Comment 4 Aleksey Chernov 2023-01-01 06:26:38 UTC

Created attachment 846322 [details, diff]
0001-Compile-warnings-errors-fixed-strcasecmp-missing-pro.patch

Or apply this patch to current version.

Comment 5 Larry the Git Cow gentoo-dev

2023-01-03 10:43:13 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=09803522a2796b647f85a4aaa4e877792fefccf5

commit 09803522a2796b647f85a4aaa4e877792fefccf5
Author:     Andrey Grozin <grozin@gentoo.org>
AuthorDate: 2023-01-03 10:42:58 +0000
Commit:     Andrey Grozin <grozin@gentoo.org>
CommitDate: 2023-01-03 10:42:58 +0000

    app-text/crengine-ng: compilation fixes
    
    Closes: https://bugs.gentoo.org/889078
    Signed-off-by: Andrey Grozin <grozin@gentoo.org>

 app-text/crengine-ng/crengine-ng-0.9.4-r1.ebuild   | 60 ++++++++++++++++++++++
 app-text/crengine-ng/files/crengine-ng-0.9.4.patch | 55 ++++++++++++++++++++
 2 files changed, 115 insertions(+)