Bug 888825

Summary:	net-libs/libtorrent-rasterbar-2.0.7: never builds client_test; add USE=example
Product:	Gentoo Linux	Reporter:	outoftime <koutoftimer>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	minor	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/35081
Whiteboard:
Package list:		Runtime testing required:	---

Description outoftime 2022-12-29 04:47:15 UTC

`client_test`[1] executable is only built when `build_examples`[2] is turned on but it is hardcoded to "OFF"[3].

Not sure why it is like that, IMHO "examples" use flag to allow turning on `build_examples` should be added.

1: https://github.com/arvidn/libtorrent/blob/95afba30e9acfd8411076a0b05f7ca69bf33b9bb/examples/CMakeLists.txt#L22
2: https://github.com/arvidn/libtorrent/blob/RC_2_0/CMakeLists.txt#L697
3: https://gitweb.gentoo.org/repo/gentoo.git/tree/net-libs/libtorrent-rasterbar/libtorrent-rasterbar-2.0.7.ebuild#n49

Reproducible: Always

Comment 1 Larry the Git Cow gentoo-dev

2024-01-30 09:59:28 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b9429c4dc799f2dc53453f5ee194113ec6f3365d

commit b9429c4dc799f2dc53453f5ee194113ec6f3365d
Author:     Alfred Wingate <parona@protonmail.com>
AuthorDate: 2024-01-29 17:19:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-30 09:58:41 +0000

    net-libs/libtorrent-rasterbar: exclude broken tests + add examples
    
    Closes: https://bugs.gentoo.org/888825
    Closes: https://bugs.gentoo.org/889832
    Closes: https://bugs.gentoo.org/915512
    Signed-off-by: Alfred Wingate <parona@protonmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/35081
    Signed-off-by: Sam James <sam@gentoo.org>

 .../libtorrent-rasterbar-2.0.9-r1.ebuild           | 112 +++++++++++++++++++++
 1 file changed, 112 insertions(+)